Convert first letter into a pseudo element.

Source/core/dom/RenderTreeBuilder.cpp

Index: Source/core/dom/RenderTreeBuilder.cpp
diff --git a/Source/core/dom/RenderTreeBuilder.cpp b/Source/core/dom/RenderTreeBuilder.cpp
index 7572603e73763b11ab81fd4bb3a7ae75ca1aa8b9..3c62d9c8f2ee4badc0bac4eb3384c37f6eb22d41 100644
--- a/Source/core/dom/RenderTreeBuilder.cpp
+++ b/Source/core/dom/RenderTreeBuilder.cpp
@@ -29,8 +29,10 @@
 #include "core/HTMLNames.h"
 #include "core/SVGNames.h"
 #include "core/css/resolver/StyleResolver.h"
+#include "core/dom/FirstLetterPseudoElement.h"
 #include "core/dom/Fullscreen.h"
 #include "core/dom/Node.h"
+#include "core/dom/PseudoElement.h"
 #include "core/dom/Text.h"
 #include "core/rendering/RenderFullScreen.h"
 #include "core/rendering/RenderObject.h"
@@ -54,6 +56,9 @@ RenderObject* RenderTreeBuilder::nextRenderer() const
     if (m_renderingParent->needsAttach())

[Julien - ping for review, 2014/10/09 18:24:48]

You're checking m_renderingParent->needsAttach() for an element that is *not*
the right parent and that's probably wrong. We could change the constructor to
point to the right parent and that would remove the code in parentRenderer().

[dsinclair, 2014/10/09 21:14:22]

Are you saying this is an existing issue, or due to the way
FirstLetterPseudoElement is built?

[Julien - ping for review, 2014/10/10 14:47:07]

I was confused by the logic actually and we have the right parent. However the
following logic seems unneeded and Dan explained to me that this is to disable
creating the renderer.

[dsinclair, 2014/10/10 18:06:53]

Acknowledged.

         return 0;
 
+    if (element && element->isFirstLetterPseudoElement())
+        return FirstLetterPseudoElement::firstLetterTextRenderer(*element);

[Julien - ping for review, 2014/10/09 18:24:48]

If we keep the code in parentRenderer(), there is an inconsistency here as we
check for top layer in this function but not in the other one.

[dsinclair, 2014/10/09 21:14:22]

In what cases is there a top layer? Is this something you think is specific to
first-letter or an existing issue?

[Julien - ping for review, 2014/10/10 14:47:07]

top layer is a DOM Element API so it won't happen on pseudo but I like to keep
the consistency to avoid being bitten back later.

[dsinclair, 2014/10/10 18:06:52]

Code removed from parentRenderer().

+
     return NodeRenderingTraversal::nextSiblingRenderer(m_node);
 }
 
@@ -63,6 +68,11 @@ RenderObject* RenderTreeBuilder::parentRenderer() const
 
     Element* element = m_node->isElementNode() ? toElement(m_node) : 0;
 
+    if (element && element->isFirstLetterPseudoElement()) {
+        RenderObject* nextRenderer = FirstLetterPseudoElement::firstLetterTextRenderer(*element);
+        return nextRenderer ? nextRenderer->parent() : nullptr;
+    }
+
     if (element && m_renderingParent->renderer()) {
         // FIXME: Guarding this by m_renderingParent->renderer() isn't quite right as the spec for
         // top layer only talks about display: none ancestors so putting a <dialog> inside an