Convert first letter into a pseudo element.

Source/core/dom/RenderTreeBuilder.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 11 matching lines @@
  * Boston, MA 02110-1301, USA.
  *
  */
 
 #include "config.h"
 #include "core/dom/RenderTreeBuilder.h"
 
 #include "core/HTMLNames.h"
 #include "core/SVGNames.h"
 #include "core/css/resolver/StyleResolver.h"
+#include "core/dom/FirstLetterPseudoElement.h"
 #include "core/dom/Fullscreen.h"
 #include "core/dom/Node.h"
+#include "core/dom/PseudoElement.h"
 #include "core/dom/Text.h"
 #include "core/rendering/RenderFullScreen.h"
 #include "core/rendering/RenderObject.h"
 #include "core/rendering/RenderText.h"
 #include "core/rendering/RenderView.h"
 #include "core/svg/SVGElement.h"
 #include "platform/RuntimeEnabledFeatures.h"
 
 namespace blink {
 
 RenderObject* RenderTreeBuilder::nextRenderer() const
 {
     ASSERT(m_renderingParent);
 
     Element* element = m_node->isElementNode() ? toElement(m_node) : 0;
 
     if (element && element->isInTopLayer())
         return NodeRenderingTraversal::nextInTopLayer(element);
 
     // Avoid an O(N^2) walk over the children when reattaching all children of a node.
     if (m_renderingParent->needsAttach())

[Julien - ping for review, 2014/10/09 18:24:48]

You're checking m_renderingParent->needsAttach() for an element that is *not*
the right parent and that's probably wrong. We could change the constructor to
point to the right parent and that would remove the code in parentRenderer().

[dsinclair, 2014/10/09 21:14:22]

Are you saying this is an existing issue, or due to the way
FirstLetterPseudoElement is built?

[Julien - ping for review, 2014/10/10 14:47:07]

I was confused by the logic actually and we have the right parent. However the
following logic seems unneeded and Dan explained to me that this is to disable
creating the renderer.

[dsinclair, 2014/10/10 18:06:53]

Acknowledged.

         return 0;
 
+    if (element && element->isFirstLetterPseudoElement())
+        return FirstLetterPseudoElement::firstLetterTextRenderer(*element);

[Julien - ping for review, 2014/10/09 18:24:48]

If we keep the code in parentRenderer(), there is an inconsistency here as we
check for top layer in this function but not in the other one.

[dsinclair, 2014/10/09 21:14:22]

In what cases is there a top layer? Is this something you think is specific to
first-letter or an existing issue?

[Julien - ping for review, 2014/10/10 14:47:07]

top layer is a DOM Element API so it won't happen on pseudo but I like to keep
the consistency to avoid being bitten back later.

[dsinclair, 2014/10/10 18:06:52]

Code removed from parentRenderer().

+
     return NodeRenderingTraversal::nextSiblingRenderer(m_node);
 }
 
 RenderObject* RenderTreeBuilder::parentRenderer() const
 {
     ASSERT(m_renderingParent);
 
     Element* element = m_node->isElementNode() ? toElement(m_node) : 0;
 
+    if (element && element->isFirstLetterPseudoElement()) {
+        RenderObject* nextRenderer = FirstLetterPseudoElement::firstLetterTextRenderer(*element);
+        return nextRenderer ? nextRenderer->parent() : nullptr;
+    }
+
     if (element && m_renderingParent->renderer()) {
         // FIXME: Guarding this by m_renderingParent->renderer() isn't quite right as the spec for
         // top layer only talks about display: none ancestors so putting a <dialog> inside an
         // <optgroup> seems like it should still work even though this check will prevent it.
         if (element->isInTopLayer())
             return m_node->document().renderView();
     }
 
     return m_renderingParent->renderer();
 }
@@ skipping 92 matching lines @@
     newRenderer->setFlowThreadState(parentRenderer->flowThreadState());
 
     RenderObject* nextRenderer = this->nextRenderer();
     textNode->setRenderer(newRenderer);
     // Parent takes care of the animations, no need to call setAnimatableStyle.
     newRenderer->setStyle(m_style.release());
     parentRenderer->addChild(newRenderer, nextRenderer);
 }
 
 }