Convert first letter into a pseudo element.

Source/core/dom/RenderTreeBuilder.cpp

Index: Source/core/dom/RenderTreeBuilder.cpp
diff --git a/Source/core/dom/RenderTreeBuilder.cpp b/Source/core/dom/RenderTreeBuilder.cpp
index 7572603e73763b11ab81fd4bb3a7ae75ca1aa8b9..dfb3033190660486cc76f52425332494d2009789 100644
--- a/Source/core/dom/RenderTreeBuilder.cpp
+++ b/Source/core/dom/RenderTreeBuilder.cpp
@@ -29,8 +29,10 @@
 #include "core/HTMLNames.h"
 #include "core/SVGNames.h"
 #include "core/css/resolver/StyleResolver.h"
+#include "core/dom/FirstLetterPseudoElement.h"
 #include "core/dom/Fullscreen.h"
 #include "core/dom/Node.h"
+#include "core/dom/PseudoElement.h"
 #include "core/dom/Text.h"
 #include "core/rendering/RenderFullScreen.h"
 #include "core/rendering/RenderObject.h"
@@ -50,8 +52,11 @@ RenderObject* RenderTreeBuilder::nextRenderer() const
     if (element && element->isInTopLayer())
         return NodeRenderingTraversal::nextInTopLayer(element);
 
+    if (element && element->isFirstLetterPseudoElement())
+        return FirstLetterPseudoElement::firstLetterTextRenderer(*element);
+
     // Avoid an O(N^2) walk over the children when reattaching all children of a node.
-    if (m_renderingParent->needsAttach())
+    if (m_renderingParent->node() && m_renderingParent->node()->needsAttach())

[esprehn, 2014/10/11 04:46:20]

This is not correct.

[esprehn, 2014/10/11 04:49:34]

Sorry, this is correct, it just seems really gross to have to deal with non
node() m_renderingParent only for first letter. We can land this as-is and
figure it out later though. This patch is a huge improvement either way.

[dsinclair, 2014/10/14 14:31:27]

Acknowledged.

         return 0;
 
     return NodeRenderingTraversal::nextSiblingRenderer(m_node);
@@ -63,15 +68,15 @@ RenderObject* RenderTreeBuilder::parentRenderer() const
 
     Element* element = m_node->isElementNode() ? toElement(m_node) : 0;
 
-    if (element && m_renderingParent->renderer()) {
-        // FIXME: Guarding this by m_renderingParent->renderer() isn't quite right as the spec for
+    if (element && m_renderingParent) {
+        // FIXME: Guarding this by m_renderingParent isn't quite right as the spec for
         // top layer only talks about display: none ancestors so putting a <dialog> inside an
         // <optgroup> seems like it should still work even though this check will prevent it.
         if (element->isInTopLayer())
             return m_node->document().renderView();
     }
 
-    return m_renderingParent->renderer();
+    return m_renderingParent;
 }
 
 bool RenderTreeBuilder::shouldCreateRenderer() const
@@ -80,11 +85,12 @@ bool RenderTreeBuilder::shouldCreateRenderer() const
         return false;
     if (m_node->isSVGElement()) {
         // SVG elements only render when inside <svg>, or if the element is an <svg> itself.
-        if (!isSVGSVGElement(*m_node) && !m_renderingParent->isSVGElement())
+        if (!isSVGSVGElement(*m_node) && !(m_renderingParent->node() && m_renderingParent->node()->isSVGElement()))

[esprehn, 2014/10/11 04:46:20]

propagate the ! through it, it's very hard to read these cases.

[dsinclair, 2014/10/14 14:31:27]

Done.

             return false;
         if (!toSVGElement(m_node)->isValid())
             return false;
     }
+
     RenderObject* parentRenderer = this->parentRenderer();
     if (!parentRenderer)
         return false;