Convert first letter into a pseudo element.

Source/core/dom/RenderTreeBuilder.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 11 matching lines @@
  * Boston, MA 02110-1301, USA.
  *
  */
 
 #include "config.h"
 #include "core/dom/RenderTreeBuilder.h"
 
 #include "core/HTMLNames.h"
 #include "core/SVGNames.h"
 #include "core/css/resolver/StyleResolver.h"
+#include "core/dom/FirstLetterPseudoElement.h"
 #include "core/dom/Fullscreen.h"
 #include "core/dom/Node.h"
+#include "core/dom/PseudoElement.h"
 #include "core/dom/Text.h"
 #include "core/rendering/RenderFullScreen.h"
 #include "core/rendering/RenderObject.h"
 #include "core/rendering/RenderText.h"
 #include "core/rendering/RenderView.h"
 #include "core/svg/SVGElement.h"
 #include "platform/RuntimeEnabledFeatures.h"
 
 namespace blink {
 
 RenderObject* RenderTreeBuilder::nextRenderer() const
 {
     ASSERT(m_renderingParent);
 
     Element* element = m_node->isElementNode() ? toElement(m_node) : 0;
 
     if (element && element->isInTopLayer())
         return NodeRenderingTraversal::nextInTopLayer(element);
 
+    if (element && element->isFirstLetterPseudoElement())
+        return FirstLetterPseudoElement::firstLetterTextRenderer(*element);
+
     // Avoid an O(N^2) walk over the children when reattaching all children of a node.
-    if (m_renderingParent->needsAttach())
+    if (m_renderingParent->node() && m_renderingParent->node()->needsAttach())

[esprehn, 2014/10/11 04:46:20]

This is not correct.

[esprehn, 2014/10/11 04:49:34]

Sorry, this is correct, it just seems really gross to have to deal with non
node() m_renderingParent only for first letter. We can land this as-is and
figure it out later though. This patch is a huge improvement either way.

[dsinclair, 2014/10/14 14:31:27]

Acknowledged.

         return 0;
 
     return NodeRenderingTraversal::nextSiblingRenderer(m_node);
 }
 
 RenderObject* RenderTreeBuilder::parentRenderer() const
 {
     ASSERT(m_renderingParent);
 
     Element* element = m_node->isElementNode() ? toElement(m_node) : 0;
 
-    if (element && m_renderingParent->renderer()) {
-        // FIXME: Guarding this by m_renderingParent->renderer() isn't quite right as the spec for
+    if (element && m_renderingParent) {
+        // FIXME: Guarding this by m_renderingParent isn't quite right as the spec for
         // top layer only talks about display: none ancestors so putting a <dialog> inside an
         // <optgroup> seems like it should still work even though this check will prevent it.
         if (element->isInTopLayer())
             return m_node->document().renderView();
     }
 
-    return m_renderingParent->renderer();
+    return m_renderingParent;
 }
 
 bool RenderTreeBuilder::shouldCreateRenderer() const
 {
     if (!m_renderingParent)
         return false;
     if (m_node->isSVGElement()) {
         // SVG elements only render when inside <svg>, or if the element is an <svg> itself.
-        if (!isSVGSVGElement(*m_node) && !m_renderingParent->isSVGElement())
+        if (!isSVGSVGElement(*m_node) && !(m_renderingParent->node() && m_renderingParent->node()->isSVGElement()))

[esprehn, 2014/10/11 04:46:20]

propagate the ! through it, it's very hard to read these cases.

[dsinclair, 2014/10/14 14:31:27]

Done.

             return false;
         if (!toSVGElement(m_node)->isValid())
             return false;
     }
+
     RenderObject* parentRenderer = this->parentRenderer();
     if (!parentRenderer)
         return false;
     if (!parentRenderer->canHaveChildren())
         return false;
     return true;
 }
 
 RenderStyle& RenderTreeBuilder::style() const
 {
@@ skipping 70 matching lines @@
     newRenderer->setFlowThreadState(parentRenderer->flowThreadState());
 
     RenderObject* nextRenderer = this->nextRenderer();
     textNode->setRenderer(newRenderer);
     // Parent takes care of the animations, no need to call setAnimatableStyle.
     newRenderer->setStyle(m_style.release());
     parentRenderer->addChild(newRenderer, nextRenderer);
 }
 
 }