Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 571563002: Remove make-file-arrays.py script (Closed)

Created:
6 years, 3 months ago by vivekg_samsung
Modified:
5 years, 11 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove make-file-arrays.py script Removing the script used to generate the string arrays for blink. BUG=312586 R=jochen@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188397

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -210 lines) Patch
D Source/build/make_file_arrays.gni View 1 chunk +0 lines, -49 lines 0 comments Download
D Source/build/scripts/make-file-arrays.py View 1 chunk +0 lines, -160 lines 0 comments Download
M Source/modules/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
vivekg
Removing the scripts which are now unused. PTAL, thanks!
5 years, 11 months ago (2015-01-14 14:25:02 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-14 14:29:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/571563002/1
5 years, 11 months ago (2015-01-14 15:57:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=188397
5 years, 11 months ago (2015-01-14 17:11:35 UTC) #7
Zhenyao Mo
5 years, 11 months ago (2015-01-14 18:34:26 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/854683002/ by zmo@chromium.org.

The reason for reverting is: Had to revert this one because
https://codereview.chromium.org/573553002/ is reverted.

Powered by Google App Engine
This is Rietveld 408576698