Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1319)

Unified Diff: content/public/browser/content_browser_client.cc

Issue 571483002: Refactor content client to include a single Request/CancelPermission method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@geoloc_permission
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/browser/content_browser_client.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/content_browser_client.cc
diff --git a/content/public/browser/content_browser_client.cc b/content/public/browser/content_browser_client.cc
index bb2d7cff3cee50e5e92fc45f1c4e5b9cc0ec154e..50cb6345ba773a86531accdc4dd62fba886c86ac 100644
--- a/content/public/browser/content_browser_client.cc
+++ b/content/public/browser/content_browser_client.cc
@@ -212,7 +212,9 @@ ContentBrowserClient::CheckDesktopNotificationPermission(
return blink::WebNotificationPermissionAllowed;
}
-void ContentBrowserClient::RequestGeolocationPermission(
+
+void ContentBrowserClient::RequestPermission(
+ PermissionType permission,
WebContents* web_contents,
int bridge_id,
const GURL& requesting_frame,
@@ -221,32 +223,13 @@ void ContentBrowserClient::RequestGeolocationPermission(
result_callback.Run(true);
}
-// TODO(miguelg): Create a small interface to represent a permission request
-// instead of adding one method per permission and action.
-void ContentBrowserClient::CancelGeolocationPermissionRequest(
+void ContentBrowserClient::CancelPermissionRequest(
+ content::PermissionType permission,
WebContents* web_contents,
int bridge_id,
const GURL& requesting_frame) {
}
-void ContentBrowserClient::RequestMidiSysExPermission(
- WebContents* web_contents,
- int bridge_id,
- const GURL& requesting_frame,
- bool user_gesture,
- base::Callback<void(bool)> result_callback,
- base::Closure* cancel_callback) {
- result_callback.Run(true);
-}
-
-void ContentBrowserClient::RequestProtectedMediaIdentifierPermission(
- WebContents* web_contents,
- const GURL& origin,
- base::Callback<void(bool)> result_callback,
- base::Closure* cancel_callback) {
- result_callback.Run(true);
-}
-
bool ContentBrowserClient::CanCreateWindow(
const GURL& opener_url,
const GURL& opener_top_level_frame_url,
« no previous file with comments | « content/public/browser/content_browser_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698