Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Side by Side Diff: content/public/browser/content_browser_client.cc

Issue 571483002: Refactor content client to include a single Request/CancelPermission method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@geoloc_permission
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/public/browser/content_browser_client.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/public/browser/content_browser_client.h" 5 #include "content/public/browser/content_browser_client.h"
6 6
7 #include "base/files/file_path.h" 7 #include "base/files/file_path.h"
8 #include "ui/gfx/image/image_skia.h" 8 #include "ui/gfx/image/image_skia.h"
9 #include "url/gurl.h" 9 #include "url/gurl.h"
10 10
(...skipping 194 matching lines...) Expand 10 before | Expand all | Expand 10 after
205 } 205 }
206 206
207 blink::WebNotificationPermission 207 blink::WebNotificationPermission
208 ContentBrowserClient::CheckDesktopNotificationPermission( 208 ContentBrowserClient::CheckDesktopNotificationPermission(
209 const GURL& source_origin, 209 const GURL& source_origin,
210 ResourceContext* context, 210 ResourceContext* context,
211 int render_process_id) { 211 int render_process_id) {
212 return blink::WebNotificationPermissionAllowed; 212 return blink::WebNotificationPermissionAllowed;
213 } 213 }
214 214
215 void ContentBrowserClient::RequestGeolocationPermission( 215
216 void ContentBrowserClient::RequestPermission(
217 PermissionType permission,
216 WebContents* web_contents, 218 WebContents* web_contents,
217 int bridge_id, 219 int bridge_id,
218 const GURL& requesting_frame, 220 const GURL& requesting_frame,
219 bool user_gesture, 221 bool user_gesture,
220 const base::Callback<void(bool)>& result_callback) { 222 const base::Callback<void(bool)>& result_callback) {
221 result_callback.Run(true); 223 result_callback.Run(true);
222 } 224 }
223 225
224 // TODO(miguelg): Create a small interface to represent a permission request 226 void ContentBrowserClient::CancelPermissionRequest(
225 // instead of adding one method per permission and action. 227 content::PermissionType permission,
226 void ContentBrowserClient::CancelGeolocationPermissionRequest(
227 WebContents* web_contents, 228 WebContents* web_contents,
228 int bridge_id, 229 int bridge_id,
229 const GURL& requesting_frame) { 230 const GURL& requesting_frame) {
230 } 231 }
231 232
232 void ContentBrowserClient::RequestMidiSysExPermission(
233 WebContents* web_contents,
234 int bridge_id,
235 const GURL& requesting_frame,
236 bool user_gesture,
237 base::Callback<void(bool)> result_callback,
238 base::Closure* cancel_callback) {
239 result_callback.Run(true);
240 }
241
242 void ContentBrowserClient::RequestProtectedMediaIdentifierPermission(
243 WebContents* web_contents,
244 const GURL& origin,
245 base::Callback<void(bool)> result_callback,
246 base::Closure* cancel_callback) {
247 result_callback.Run(true);
248 }
249
250 bool ContentBrowserClient::CanCreateWindow( 233 bool ContentBrowserClient::CanCreateWindow(
251 const GURL& opener_url, 234 const GURL& opener_url,
252 const GURL& opener_top_level_frame_url, 235 const GURL& opener_top_level_frame_url,
253 const GURL& source_origin, 236 const GURL& source_origin,
254 WindowContainerType container_type, 237 WindowContainerType container_type,
255 const GURL& target_url, 238 const GURL& target_url,
256 const Referrer& referrer, 239 const Referrer& referrer,
257 WindowOpenDisposition disposition, 240 WindowOpenDisposition disposition,
258 const blink::WebWindowFeatures& features, 241 const blink::WebWindowFeatures& features,
259 bool user_gesture, 242 bool user_gesture,
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
353 #endif 336 #endif
354 337
355 bool ContentBrowserClient::CheckMediaAccessPermission( 338 bool ContentBrowserClient::CheckMediaAccessPermission(
356 BrowserContext* browser_context, 339 BrowserContext* browser_context,
357 const GURL& security_origin, 340 const GURL& security_origin,
358 MediaStreamType type) { 341 MediaStreamType type) {
359 return false; 342 return false;
360 } 343 }
361 344
362 } // namespace content 345 } // namespace content
OLDNEW
« no previous file with comments | « content/public/browser/content_browser_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698