Declare a new name for CompositingSurface completion callback.

Declare a new name for CopyFromCompositingSurface completion
callback. This gives us the flexibility to change the
callback at just one place, if we want to add more
parameters in future like ReasonForFailure.

BUG=

Committed: https://crrev.com/6778f758aff312b3a1003296d0d2ef89008db046
Cr-Commit-Position: refs/heads/master@{#295309}

[sivag, 2014-09-16 14:01:29]

siva.gunturi@samsung.com changed reviewers:
+ piman@chromium.org, sievers@chromium.org, sky@chromium.org

[sivag, 2014-09-16 14:01:30]

ptal..

[piman, 2014-09-16 20:24:57]

https://codereview.chromium.org/571413002/diff/20001/content/browser/renderer...
File content/browser/renderer_host/render_widget_host_view_base.h (right):

https://codereview.chromium.org/571413002/diff/20001/content/browser/renderer...
content/browser/renderer_host/render_widget_host_view_base.h:65: typedef const
base::Callback<void(bool, const SkBitmap&)> CompletionCallback;
Can we either expand the name, or scope it?

content::CompletionCallback doesn't convey the fact that it has to do with
CopyFromCompositingSurface, and is too generic to be in the content namespace.

How about content::CopyFromCompositingSurfaceCallback?

[sivag, 2014-09-17 11:17:11]

ptal..

https://codereview.chromium.org/571413002/diff/20001/content/browser/renderer...
File content/browser/renderer_host/render_widget_host_view_base.h (right):

https://codereview.chromium.org/571413002/diff/20001/content/browser/renderer...
content/browser/renderer_host/render_widget_host_view_base.h:65: typedef const
base::Callback<void(bool, const SkBitmap&)> CompletionCallback;
On 2014/09/16 20:24:56, piman (Very slow to review) wrote:
> Can we either expand the name, or scope it?
> 
> content::CompletionCallback doesn't convey the fact that it has to do with
> CopyFromCompositingSurface, and is too generic to be in the content namespace.
> 
> How about content::CopyFromCompositingSurfaceCallback?

Done.

[piman, 2014-09-17 17:28:07]

lgtm

[sivag, 2014-09-17 17:29:02]

The CQ bit was checked by siva.gunturi@samsung.com

[commit-bot: I haz the power, 2014-09-17 17:30:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/571413002/60001

[commit-bot: I haz the power, 2014-09-17 18:51:20]

Committed patchset #4 (id:60001) as e93599325e2a6f054c9afba7dbcc5fdda4939eed

[commit-bot: I haz the power, 2014-09-17 18:52:02]

Patchset 4 (id:??) landed as
https://crrev.com/6778f758aff312b3a1003296d0d2ef89008db046
Cr-Commit-Position: refs/heads/master@{#295309}