Chromium Code Reviews

Issue 571413002: Declare a new name for CompositingSurface completion callback. (Closed)

Created:
6 years, 3 months ago by sivag
Modified:
6 years, 3 months ago
Reviewers:
no sievers, sky, piman
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, mkwst+moarreviews-content_chromium.org, nasko+codewatch_chromium.org, jam, penghuang+watch_chromium.org, yukishiino+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Declare a new name for CopyFromCompositingSurface completion callback. This gives us the flexibility to change the callback at just one place, if we want to add more parameters in future like ReasonForFailure. BUG= Committed: https://crrev.com/6778f758aff312b3a1003296d0d2ef89008db046 Cr-Commit-Position: refs/heads/master@{#295309}

Patch Set 1 #

Patch Set 2 : Added TODO comments #

Total comments: 2

Patch Set 3 : Callback name changed. #

Patch Set 4 : Fixed build issue. #

Unified diffs Side-by-side diffs Stats (+23 lines, -17 lines)
M content/browser/compositor/delegated_frame_host.h View 2 chunks +5 lines, -5 lines 0 comments
M content/browser/compositor/delegated_frame_host.cc View 1 chunk +1 line, -1 line 0 comments
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 chunk +1 line, -1 line 0 comments
M content/browser/frame_host/render_widget_host_view_guest.h View 1 chunk +1 line, -1 line 0 comments
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 chunk +1 line, -1 line 0 comments
M content/browser/renderer_host/render_widget_host_view_android.h View 1 chunk +1 line, -1 line 0 comments
M content/browser/renderer_host/render_widget_host_view_android.cc View 2 chunks +2 lines, -2 lines 0 comments
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +1 line, -1 line 0 comments
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +1 line, -1 line 0 comments
M content/browser/renderer_host/render_widget_host_view_base.h View 2 chunks +7 lines, -1 line 0 comments
M content/test/test_render_view_host.h View 1 chunk +1 line, -1 line 0 comments
M content/test/test_render_view_host.cc View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 9 (2 generated)
sivag
ptal..
6 years, 3 months ago (2014-09-16 14:01:30 UTC) #2
piman
https://codereview.chromium.org/571413002/diff/20001/content/browser/renderer_host/render_widget_host_view_base.h File content/browser/renderer_host/render_widget_host_view_base.h (right): https://codereview.chromium.org/571413002/diff/20001/content/browser/renderer_host/render_widget_host_view_base.h#newcode65 content/browser/renderer_host/render_widget_host_view_base.h:65: typedef const base::Callback<void(bool, const SkBitmap&)> CompletionCallback; Can we either ...
6 years, 3 months ago (2014-09-16 20:24:57 UTC) #3
sivag
ptal.. https://codereview.chromium.org/571413002/diff/20001/content/browser/renderer_host/render_widget_host_view_base.h File content/browser/renderer_host/render_widget_host_view_base.h (right): https://codereview.chromium.org/571413002/diff/20001/content/browser/renderer_host/render_widget_host_view_base.h#newcode65 content/browser/renderer_host/render_widget_host_view_base.h:65: typedef const base::Callback<void(bool, const SkBitmap&)> CompletionCallback; On 2014/09/16 ...
6 years, 3 months ago (2014-09-17 11:17:11 UTC) #4
piman
lgtm
6 years, 3 months ago (2014-09-17 17:28:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571413002/60001
6 years, 3 months ago (2014-09-17 17:30:09 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001) as e93599325e2a6f054c9afba7dbcc5fdda4939eed
6 years, 3 months ago (2014-09-17 18:51:20 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 18:52:02 UTC) #9
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/6778f758aff312b3a1003296d0d2ef89008db046
Cr-Commit-Position: refs/heads/master@{#295309}

Powered by Google App Engine