Declare a new name for CompositingSurface completion callback.

content/browser/renderer_host/render_widget_host_view_base.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
 
 #if defined(OS_MACOSX)
 #include <OpenGL/OpenGL.h>
 #endif
@@ skipping 41 matching lines @@
 namespace content {
 class BrowserAccessibilityDelegate;
 class BrowserAccessibilityManager;
 class SyntheticGesture;
 class SyntheticGestureTarget;
 class WebCursor;
 struct DidOverscrollParams;
 struct NativeWebKeyboardEvent;
 struct WebPluginGeometry;
 
+// TODO(Sikugu): Though we have the return status of the result here,
+// we should add the reason for failure as a new parameter to handle cases
+// efficiently.
+typedef const base::Callback<void(bool, const SkBitmap&)> CompletionCallback;

[piman, 2014/09/16 20:24:56]

Can we either expand the name, or scope it?

content::CompletionCallback doesn't convey the fact that it has to do with
CopyFromCompositingSurface, and is too generic to be in the content namespace.

How about content::CopyFromCompositingSurfaceCallback?

[sivag, 2014/09/17 11:17:11]

Done.

+
 // Basic implementation shared by concrete RenderWidgetHostView subclasses.
 class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,
                                                 public IPC::Listener {
  public:
   virtual ~RenderWidgetHostViewBase();
 
   // RenderWidgetHostView implementation.
   virtual void SetBackgroundOpaque(bool opaque) OVERRIDE;
   virtual bool GetBackgroundOpaque() OVERRIDE;
   virtual ui::TextInputClient* GetTextInputClient() OVERRIDE;
@@ skipping 176 matching lines @@
   virtual void SelectionBoundsChanged(
       const ViewHostMsg_SelectionBounds_Params& params) = 0;
 
   // Copies the contents of the compositing surface, providing a new SkBitmap
   // result via an asynchronously-run |callback|. |src_subrect| is specified in
   // layer space coordinates for the current platform (e.g., DIP for Aura/Mac,
   // physical for Android), and is the region to be copied from this view. The
   // copy is then scaled to a SkBitmap of size |dst_size|. |callback| is run
   // with true on success, false otherwise. A smaller region than |src_subrect|
   // may be copied if the underlying surface is smaller than |src_subrect|.
-  virtual void CopyFromCompositingSurface(
-      const gfx::Rect& src_subrect,
-      const gfx::Size& dst_size,
-      const base::Callback<void(bool, const SkBitmap&)>& callback,
-      const SkColorType color_type) = 0;
+  virtual void CopyFromCompositingSurface(const gfx::Rect& src_subrect,
+                                          const gfx::Size& dst_size,
+                                          CompletionCallback& callback,
+                                          const SkColorType color_type) = 0;
 
   // Copies the contents of the compositing surface, populating the given
   // |target| with YV12 image data. |src_subrect| is specified in layer space
   // coordinates for the current platform (e.g., DIP for Aura/Mac, physical for
   // Android), and is the region to be copied from this view. The copy is then
   // scaled and letterboxed with black borders to fit |target|. Finally,
   // |callback| is asynchronously run with true/false for
   // success/failure. |target| must point to an allocated, YV12 video frame of
   // the intended size. This operation will fail if there is no available
   // compositing surface.
@@ skipping 161 matching lines @@
   base::OneShotTimer<RenderWidgetHostViewBase> flush_input_timer_;
 
   base::WeakPtrFactory<RenderWidgetHostViewBase> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewBase);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_