Issue 571133003: Only force fastbuild=1 when use_goma if not already set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 571133003: Only force fastbuild=1 when use_goma if not already set (Closed)

Created:
6 years, 3 months ago by scottmg

Modified:
6 years, 3 months ago

Reviewers:
jam

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Only force fastbuild=1 when use_goma if not already set R=jam@chromium.org BUG=406457 Committed: https://crrev.com/e14e79beabc1ad9279535834f0a3ea38298e05cc Cr-Commit-Position: refs/heads/master@{#294914}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/common.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571133003/1

6 years, 3 months ago (2014-09-15 20:52:36 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as 390314b86c0df2d8d41bd073adb2566fc8ccb85c

6 years, 3 months ago (2014-09-15 23:18:40 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-15 23:21:55 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e14e79beabc1ad9279535834f0a3ea38298e05cc
Cr-Commit-Position: refs/heads/master@{#294914}