Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Side by Side Diff: build/common.gypi

Issue 571133003: Only force fastbuild=1 when use_goma if not already set (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 2292 matching lines...) Expand 10 before | Expand all | Expand 10 after
2303 2303
2304 ['desktop_linux==1 and use_aura==1 and use_x11==1', { 2304 ['desktop_linux==1 and use_aura==1 and use_x11==1', {
2305 'use_clipboard_aurax11%': 1, 2305 'use_clipboard_aurax11%': 1,
2306 }], 2306 }],
2307 2307
2308 ['OS=="win" and use_goma==1', { 2308 ['OS=="win" and use_goma==1', {
2309 # goma doesn't support pch yet. 2309 # goma doesn't support pch yet.
2310 'chromium_win_pch': 0, 2310 'chromium_win_pch': 0,
2311 # goma doesn't support PDB yet, so win_z7=1 or fastbuild=1. 2311 # goma doesn't support PDB yet, so win_z7=1 or fastbuild=1.
2312 'conditions': [ 2312 'conditions': [
2313 ['win_z7==0', { 2313 ['win_z7==0 and fastbuild==0', {
2314 'fastbuild': 1, 2314 'fastbuild': 1,
2315 }], 2315 }],
2316 ], 2316 ],
2317 }], 2317 }],
2318 2318
2319 ['OS=="win" and (clang==1 or asan==1)', { 2319 ['OS=="win" and (clang==1 or asan==1)', {
2320 'chromium_win_pch': 0, 2320 'chromium_win_pch': 0,
2321 }], 2321 }],
2322 2322
2323 ['host_clang==1', { 2323 ['host_clang==1', {
(...skipping 3468 matching lines...) Expand 10 before | Expand all | Expand 10 after
5792 # settings in target dicts. SYMROOT is a special case, because many other 5792 # settings in target dicts. SYMROOT is a special case, because many other
5793 # Xcode variables depend on it, including variables such as 5793 # Xcode variables depend on it, including variables such as
5794 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 5794 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
5795 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 5795 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
5796 # files to appear (when present) in the UI as actual files and not red 5796 # files to appear (when present) in the UI as actual files and not red
5797 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 5797 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
5798 # and therefore SYMROOT, needs to be set at the project level. 5798 # and therefore SYMROOT, needs to be set at the project level.
5799 'SYMROOT': '<(DEPTH)/xcodebuild', 5799 'SYMROOT': '<(DEPTH)/xcodebuild',
5800 }, 5800 },
5801 } 5801 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698