Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 57103003: Merge 232631 "This CL broke the official builders." (Closed)

Created:
7 years, 1 month ago by kareng
Modified:
7 years, 1 month ago
Reviewers:
karen
CC:
chromium-reviews, extensions-reviews_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, rginda+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Merge 232631 "This CL broke the official builders." > This CL broke the official builders. > Revert 232499 "Move ManifestHandler to top-level extensions." > > > Move ManifestHandler to top-level extensions. > > > > BUG=298586 > > R=benwells@chromium.org > > > > Review URL: https://codereview.chromium.org/52593012 > > TBR=yoz@chromium.org > > Review URL: https://codereview.chromium.org/55713004 TBR=karen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232655

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -674 lines) Patch
M chrome/browser/extensions/api/identity/experimental_identity_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/commands/commands_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_action/browser_action_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_action/page_action_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_action/script_badge_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/file_browser_handlers/file_browser_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/file_handlers/file_handlers_parser.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/i18n/default_locale_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/identity/oauth2_manifest_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/input_ime/input_components_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/managed_mode_private/managed_mode_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/media_galleries_private/media_galleries_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/omnibox/omnibox_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/plugins/plugins_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/sockets/sockets_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/speech/tts_engine_manifest_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/spellcheck/spellcheck_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/storage/storage_schema_manifest_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/system_indicator/system_indicator_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/url_handlers/url_handlers_parser.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/background_info.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/csp_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_file_util.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/extensions/incognito_handler.h View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/common/extensions/manifest_handler.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/manifest_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/extensions/manifest_handler_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/app_isolation_info.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/app_launch_info.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/content_scripts_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/externally_connectable.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/icons_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/kiosk_mode_info.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/nacl_modules_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/offline_enabled_info.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/requirements_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/sandboxed_page_info.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/settings_overrides_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/shared_module_info.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/theme_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_url_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/mime_types_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/web_accessible_resources_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/webview_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/DEPS View 1 chunk +3 lines, -7 lines 0 comments Download
D extensions/common/manifest_handler.h View 1 chunk +0 lines, -138 lines 0 comments Download
D extensions/common/manifest_handler.cc View 1 chunk +0 lines, -205 lines 0 comments Download
D extensions/common/manifest_handler_unittest.cc View 1 chunk +0 lines, -281 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kareng
7 years, 1 month ago (2013-11-03 04:28:12 UTC) #1
kareng
7 years, 1 month ago (2013-11-03 04:28:32 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r232655.

Powered by Google App Engine
This is Rietveld 408576698