chrome/common/extensions/manifest_handler_unittest.cc - Issue 57103003: Merge 232631 "This CL broke the official builders."

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/manifest_handler_unittest.cc

Issue 57103003: Merge 232631 "This CL broke the official builders." (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1690/src/

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include <string>	5 #include <string>

6 #include <vector>	6 #include <vector>

7	7

8 #include "base/files/file_path.h"	8 #include "base/files/file_path.h"

9 #include "base/memory/scoped_ptr.h"	9 #include "base/memory/scoped_ptr.h"

10 #include "base/stl_util.h"	10 #include "base/stl_util.h"

(...skipping 261 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
272 EXPECT_TRUE(	272 EXPECT_TRUE(

273 ManifestHandler::ValidateExtension(extension.get(), &error, &warnings));	273 ManifestHandler::ValidateExtension(extension.get(), &error, &warnings));

274	274

275 // Validates "a" and fails.	275 // Validates "a" and fails.

276 (new TestManifestValidator(false, true, SingleKey("a")))->Register();	276 (new TestManifestValidator(false, true, SingleKey("a")))->Register();

277 EXPECT_FALSE(	277 EXPECT_FALSE(

278 ManifestHandler::ValidateExtension(extension.get(), &error, &warnings));	278 ManifestHandler::ValidateExtension(extension.get(), &error, &warnings));

279 }	279 }

280	280

281 } // namespace extensions	281 } // namespace extensions

OLD	NEW