content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java - Issue 570783002: Fix but that ignored startRenderer in WebContentsImpl.java

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

Issue 570783002: Fix but that ignored startRenderer in WebContentsImpl.java (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove startRenderer Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java ('k') | content/public/android/java/src/org/chromium/content_public/browser/WebContents.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

index bfafff0101682b1f9befe7e51398ef99b68e538a..b66cc265cd5ac76739ee79c5a74c0c7347eac922 100644

--- a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

+++ b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

@@ -217,9 +217,8 @@ import org.chromium.content_public.browser.WebContents;

}

@Override

- public void evaluateJavaScript(String script, JavaScriptCallback callback,

- boolean startRenderer) {

- nativeEvaluateJavaScript(mNativeWebContentsAndroid, script, callback, true);

+ public void evaluateJavaScript(String script, JavaScriptCallback callback) {

+ nativeEvaluateJavaScript(mNativeWebContentsAndroid, script, callback);

}

@CalledByNative

@@ -258,5 +257,5 @@ import org.chromium.content_public.browser.WebContents;

private native void nativeBeginExitTransition(long nativeWebContentsAndroid,

String cssSelector);

private native void nativeEvaluateJavaScript(long nativeWebContentsAndroid,

- String script, JavaScriptCallback callback, boolean startRenderer);

+ String script, JavaScriptCallback callback);

}