content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 570783002: Fix but that ignored startRenderer in WebContentsImpl.java

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 570783002: Fix but that ignored startRenderer in WebContentsImpl.java (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove startRenderer Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/web_contents/web_contents_android.cc ('k') | content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index 2f48516da6752367e3395e6ea38614788940b715..451a5be5210ec68676ab6be00fd1a99a06e515d4 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -1214,18 +1214,7 @@ public class ContentViewCore

public void evaluateJavaScript(String script, JavaScriptCallback callback) {

assert mWebContents != null;

- mWebContents.evaluateJavaScript(script, callback, false);

- }

- /**

- * Injects the passed Javascript code in the current page and evaluates it.

- * If there is no page existing, a new one will be created.

- *

- * @param script The Javascript to execute.

- */

- public void evaluateJavaScriptEvenIfNotYetNavigated(String script) {

- assert mWebContents != null;

- mWebContents.evaluateJavaScript(script, null, true);

+ mWebContents.evaluateJavaScript(script, callback);

}

/**