Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 570623002: Revert "Compositor bindings for mojo html_viewer" (Closed)

Created:
6 years, 3 months ago by Dirk Pranke
Modified:
6 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, cc-bugs_chromium.org, ben+mojo_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Compositor bindings for mojo html_viewer" This reverts commit 2abb46fdc18d2110b443a9e570ea393e3b0a42c5. The patch was causing flaky compile failures on the GN try servers. TBR=jamesr@chromium.org BUG= Committed: https://crrev.com/e607d8264fcba9fee22621ac2896c7ac7c0c29d1 Cr-Commit-Position: refs/heads/master@{#294600}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -638 lines) Patch
M mojo/cc/output_surface_mojo.h View 2 chunks +2 lines, -13 lines 0 comments Download
M mojo/cc/output_surface_mojo.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M mojo/mojo_services.gypi View 3 chunks +0 lines, -8 lines 0 comments Download
M mojo/services/html_viewer/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/services/html_viewer/blink_platform_impl.h View 3 chunks +0 lines, -4 lines 0 comments Download
M mojo/services/html_viewer/blink_platform_impl.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M mojo/services/html_viewer/html_document_view.h View 5 chunks +5 lines, -11 lines 0 comments Download
M mojo/services/html_viewer/html_document_view.cc View 8 chunks +38 lines, -26 lines 0 comments Download
M mojo/services/html_viewer/html_viewer.cc View 3 chunks +11 lines, -25 lines 0 comments Download
D mojo/services/html_viewer/weblayertreeview_impl.h View 1 chunk +0 lines, -132 lines 0 comments Download
D mojo/services/html_viewer/weblayertreeview_impl.cc View 1 chunk +0 lines, -232 lines 0 comments Download
M mojo/services/public/cpp/geometry/geometry_type_converters.h View 1 chunk +0 lines, -9 lines 0 comments Download
M mojo/services/public/cpp/geometry/lib/geometry_type_converters.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M mojo/services/public/cpp/surfaces/lib/surfaces_type_converters.cc View 8 chunks +2 lines, -82 lines 0 comments Download
M mojo/services/public/cpp/surfaces/surfaces_type_converters.h View 2 chunks +0 lines, -11 lines 0 comments Download
M mojo/services/public/interfaces/geometry/geometry.mojom View 1 chunk +0 lines, -7 lines 0 comments Download
M mojo/services/public/interfaces/surfaces/quads.mojom View 6 chunks +15 lines, -46 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Dirk Pranke
Committed patchset #1 (id:1) manually as e607d82 (presubmit successful).
6 years, 3 months ago (2014-09-12 16:16:55 UTC) #1
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 16:17:00 UTC) #2
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e607d8264fcba9fee22621ac2896c7ac7c0c29d1
Cr-Commit-Position: refs/heads/master@{#294600}

Powered by Google App Engine
This is Rietveld 408576698