chrome/browser/resources/options/deletable_item_list.js - Issue 570503002: Compile chrome://settings, part 6

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/deletable_item_list.js

Issue 570503002: Compile chrome://settings, part 6 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@H_options_errors_4

Patch Set: fix asserts, rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/options/deletable_item_list.js

diff --git a/chrome/browser/resources/options/deletable_item_list.js b/chrome/browser/resources/options/deletable_item_list.js

index 33ca307f894604065c08c3e79b01d6f7ca56ad56..0d52ff07bab0d275472f3c7a551460cf0caee9d6 100644

--- a/chrome/browser/resources/options/deletable_item_list.js

+++ b/chrome/browser/resources/options/deletable_item_list.js

@@ -152,7 +152,8 @@ cr.define('options', function() {

var target = e.target;

if (target.classList.contains('row-delete-button')) {

- var listItem = this.getListItemAncestor(target);

+ var listItem = this.getListItemAncestor(

+ /** @type {HTMLElement} */(target));

var idx = this.getIndexOfListItem(listItem);

this.deleteItemAtIndex(idx);

}