Compile chrome://settings, part 6

chrome/browser/resources/options/chromeos/internet_detail.js

Index: chrome/browser/resources/options/chromeos/internet_detail.js
diff --git a/chrome/browser/resources/options/chromeos/internet_detail.js b/chrome/browser/resources/options/chromeos/internet_detail.js
index e4235695322367803a77f60db43514cf92da1965..d907ae8473a981db2e3afce543184ff8a201a03d 100644
--- a/chrome/browser/resources/options/chromeos/internet_detail.js
+++ b/chrome/browser/resources/options/chromeos/internet_detail.js
@@ -387,11 +387,13 @@ cr.define('options.internet', function() {
      * Creates an indicator event for controlled properties using
      * the same dictionary format as CoreOptionsHandler::CreateValueForPref.
      * @param {string} name The name for the Event.
-     * @param {!{value: *, controlledBy: *, recommendedValue: *}} propData
-     *     Property dictionary,
+     * @param {{value: *, controlledBy: *, recommendedValue: *}} propData
+     *     Property dictionary.
      * @private
      */
     createControlledEvent_: function(name, propData) {
+      assert('value' in propData && 'controlledBy' in propData &&
+             'recommendedValue' in propData);
       var event = new Event(name);
       event.value = {
         value: propData.value,
@@ -1569,11 +1571,14 @@ cr.define('options.internet', function() {
           onc.getActiveValue(propName);
       if (propValue == undefined)
         continue;
+      propValue = assertInstanceof(propValue, Object);

[stevenjb, 2014/11/05 20:30:15]

While I do appreciate this effort, this actually introduced a subtle bug causing
the details page not to load at all. If you could include me on the review of
any internet options related changes in the future I may be able to catch these
in advance. (FYI, fix is here: https://codereview.chromium.org/701243002/).
Thanks!

       var event;
       if (managed)
         event = detailsPage.createManagedEvent_(propName, propValue);
       else
-        event = detailsPage.createControlledEvent_(propName, propValue);
+        event = detailsPage.createControlledEvent_(propName,
+            /** @type {{value: *, controlledBy: *, recommendedValue: *}} */(
+                propValue));
       indicators[i].handlePrefChange(event);
       var forElement = $(indicators[i].getAttribute('for'));
       if (forElement) {