chrome/browser/resources/options/chromeos/third_party_ime_confirm_overlay.js - Issue 570503002: Compile chrome://settings, part 6

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/chromeos/third_party_ime_confirm_overlay.js

Issue 570503002: Compile chrome://settings, part 6 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@H_options_errors_4

Patch Set: fix asserts, rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/options/chromeos/internet_detail.js ('K') | « chrome/browser/resources/options/chromeos/proxy_rules_list.js ('k') | chrome/browser/resources/options/compiled_resources.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/chromeos/third_party_ime_confirm_overlay.js

diff --git a/chrome/browser/resources/options/chromeos/third_party_ime_confirm_overlay.js b/chrome/browser/resources/options/chromeos/third_party_ime_confirm_overlay.js

index 7b8aac549c15a0a67f212b37396669a6f5b1985b..1f2d6c3eaf4ff69cf58be881b2a89b712a01b96f 100644

--- a/chrome/browser/resources/options/chromeos/third_party_ime_confirm_overlay.js

+++ b/chrome/browser/resources/options/chromeos/third_party_ime_confirm_overlay.js

@@ -17,8 +17,9 @@ cr.define('options', function() {

this, 'thirdPartyImeConfirm',

loadTimeData.getString('thirdPartyImeConfirmOverlayTabTitle'),

'third-party-ime-confirm-overlay',

- $('third-party-ime-confirm-ok'),

- $('third-party-ime-confirm-cancel'));

+ assertInstanceof($('third-party-ime-confirm-ok'), HTMLButtonElement),

+ assertInstanceof($('third-party-ime-confirm-cancel'),

+ HTMLButtonElement));

}

cr.addSingletonGetter(ThirdPartyImeConfirmOverlay);