Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4692)

Unified Diff: chrome/browser/resources/options/chromeos/preferred_networks.js

Issue 570503002: Compile chrome://settings, part 6 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@H_options_errors_4
Patch Set: fix asserts, rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/chromeos/preferred_networks.js
diff --git a/chrome/browser/resources/options/chromeos/preferred_networks.js b/chrome/browser/resources/options/chromeos/preferred_networks.js
index 234684dac890ec451c8b162be9e0978b072dbc61..2234733329fdbf26ab933d775e6f8dc563b2d6b6 100644
--- a/chrome/browser/resources/options/chromeos/preferred_networks.js
+++ b/chrome/browser/resources/options/chromeos/preferred_networks.js
@@ -2,6 +2,13 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+cr.exportPath('options');
+
+/**
+ * @typedef {{Name: string, Type: string, servicePath: string}}
+ */
+options.PreferredNetwork;
+
cr.define('options', function() {
var Page = cr.ui.pageManager.Page;
@@ -19,7 +26,7 @@ cr.define('options', function() {
* @extends {cr.ui.pageManager.Page}
*/
function PreferredNetworks(model) {
- Page.call(this, 'preferredNetworksPage', null, 'preferredNetworksPage');
+ Page.call(this, 'preferredNetworksPage', '', 'preferredNetworksPage');
}
cr.addSingletonGetter(PreferredNetworks);
@@ -48,8 +55,7 @@ cr.define('options', function() {
/**
* Creates a list entry for a remembered network.
- * @param {{Name: string, Type: string, servicePath: string}} data
- * Description of the network.
+ * @param {options.PreferredNetwork} data Description of the network.
* @constructor
* @extends {options.DeletableItem}
*/
@@ -68,7 +74,7 @@ cr.define('options', function() {
/**
* Description of the network.
- * @type {{Name: string, Type: string, servicePath: string}}
+ * @type {?options.PreferredNetwork}
*/
data: null,
@@ -108,7 +114,10 @@ cr.define('options', function() {
this.selectionModel.unselectAll();
},
- /** @override */
+ /**
+ * @override
+ * @param {options.PreferredNetwork} entry
+ */
createItem: function(entry) {
return new PreferredNetworkListItem(entry);
},
@@ -140,8 +149,7 @@ cr.define('options', function() {
/**
* Adds a remembered network to the list.
- * @param {{Name: string, Type: string, servicePath: string}} data
- * Description of the network.
+ * @param {options.PreferredNetwork} data Description of the network.
*/
append: function(data) {
this.dataModel.push(data);

Powered by Google App Engine
This is Rietveld 408576698