tools/run-bisect-perf-regression.py - Issue 570413003: Better error messaging for perf tryjobs on windows XP.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/run-bisect-perf-regression.py

Issue 570413003: Better error messaging for perf tryjobs on windows XP. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/run-bisect-perf-regression.py

diff --git a/tools/run-bisect-perf-regression.py b/tools/run-bisect-perf-regression.py

index 364d39f3afd258a67677da306fbf793119c31446..f5f1b7ff8c3cb747e48884d6d74b5dfe483cba14 100755

--- a/tools/run-bisect-perf-regression.py

+++ b/tools/run-bisect-perf-regression.py

@@ -351,6 +351,10 @@ def _SetupAndRunPerformanceTest(config, path_to_file, path_to_goma):

Returns:

The exit code of bisect-perf-regression.py: 0 on success, otherwise 1.

"""

+ if platform.release() == 'XP':

+ print 'Windows XP is not supported for perf try jobs because it lacks '

+ print 'goma support. Please refer to crbug.com/330900.'

+ return 1

try:

with Goma(path_to_goma) as _:

config['use_goma'] = bool(path_to_goma)

« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py » ('j') | no next file with comments »