Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1049)

Side by Side Diff: tools/run-bisect-perf-regression.py

Issue 570413003: Better error messaging for perf tryjobs on windows XP. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Run Performance Test Bisect Tool 6 """Run Performance Test Bisect Tool
7 7
8 This script is used by a try bot to run the src/tools/bisect-perf-regression.py 8 This script is used by a try bot to run the src/tools/bisect-perf-regression.py
9 script with the parameters specified in src/tools/auto_bisect/bisect.cfg. 9 script with the parameters specified in src/tools/auto_bisect/bisect.cfg.
10 It will check out a copy of the depot in a subdirectory 'bisect' of the working 10 It will check out a copy of the depot in a subdirectory 'bisect' of the working
(...skipping 333 matching lines...) Expand 10 before | Expand all | Expand 10 after
344 current patch, with the parameters passed in. 344 current patch, with the parameters passed in.
345 345
346 Args: 346 Args:
347 config: The config read from run-perf-test.cfg. 347 config: The config read from run-perf-test.cfg.
348 path_to_file: Path to the bisect-perf-regression.py script. 348 path_to_file: Path to the bisect-perf-regression.py script.
349 path_to_goma: Path to goma directory. 349 path_to_goma: Path to goma directory.
350 350
351 Returns: 351 Returns:
352 The exit code of bisect-perf-regression.py: 0 on success, otherwise 1. 352 The exit code of bisect-perf-regression.py: 0 on success, otherwise 1.
353 """ 353 """
354 if platform.release() == 'XP':
355 print 'Windows XP is not supported for perf try jobs because it lacks '
356 print 'goma support. Please refer to crbug.com/330900.'
357 return 1
354 try: 358 try:
355 with Goma(path_to_goma) as _: 359 with Goma(path_to_goma) as _:
356 config['use_goma'] = bool(path_to_goma) 360 config['use_goma'] = bool(path_to_goma)
357 if config['use_goma']: 361 if config['use_goma']:
358 config['goma_dir'] = os.path.abspath(path_to_goma) 362 config['goma_dir'] = os.path.abspath(path_to_goma)
359 _RunPerformanceTest(config, path_to_file) 363 _RunPerformanceTest(config, path_to_file)
360 return 0 364 return 0
361 except RuntimeError, e: 365 except RuntimeError, e:
362 bisect_utils.OutputAnnotationStepClosed() 366 bisect_utils.OutputAnnotationStepClosed()
363 _OutputFailedResults('Error: %s' % e.message) 367 _OutputFailedResults('Error: %s' % e.message)
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
566 config, current_dir, opts.path_to_goma) 570 config, current_dir, opts.path_to_goma)
567 571
568 print ('Error: Could not load config file. Double check your changes to ' 572 print ('Error: Could not load config file. Double check your changes to '
569 'auto_bisect/bisect.cfg or run-perf-test.cfg for syntax ' 573 'auto_bisect/bisect.cfg or run-perf-test.cfg for syntax '
570 'errors.\n') 574 'errors.\n')
571 return 1 575 return 1
572 576
573 577
574 if __name__ == '__main__': 578 if __name__ == '__main__':
575 sys.exit(main()) 579 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698