Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issue 570403002: Fix bug in browser action overflow container (Closed)

Created:
6 years, 3 months ago by Devlin
Modified:
6 years, 3 months ago
Reviewers:
Finnur
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix bug in browser action overflow container Fix a bug where reording actions in the browser action overflow container can cause them all to become visible. BUG=414177 Committed: https://crrev.com/5345c6a40e86cda42fb3cd94a7af859f8f5bd9c8 Cr-Commit-Position: refs/heads/master@{#295108}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Devlin
6 years, 3 months ago (2014-09-16 15:39:59 UTC) #2
Finnur
LGTM
6 years, 3 months ago (2014-09-16 15:41:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/570403002/1
6 years, 3 months ago (2014-09-16 17:36:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 685157ce25898b41a363a933ec87f86fe05582b4
6 years, 3 months ago (2014-09-16 18:34:07 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 18:36:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5345c6a40e86cda42fb3cd94a7af859f8f5bd9c8
Cr-Commit-Position: refs/heads/master@{#295108}

Powered by Google App Engine
This is Rietveld 408576698