chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc - Issue 570403002: Fix bug in browser action overflow container

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc

Issue 570403002: Fix bug in browser action overflow container (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc

diff --git a/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc b/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc

index 5f0e25ddcb92187f699103ad3b34de6c32fe9220..86009f91d94d136157c33f46d53d95439387ff3a 100644

--- a/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc

+++ b/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc

@@ -239,7 +239,7 @@ int BrowserActionOverflowMenuController::OnPerformDrop(

// If the extension was moved to the overflow menu from the main bar, notify

// the owner.

- if (drop_index >= owner_->VisibleBrowserActions())

+ if (drop_data.index() < owner_->VisibleBrowserActions())

owner_->NotifyActionMovedToOverflow();

if (for_drop_)

« no previous file with comments | « no previous file | no next file » | no next file with comments »