android_webview/libwebviewchromium.gypi - Issue 570383002: android_webview: go back to using system ICU.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/libwebviewchromium.gypi

Issue 570383002: android_webview: go back to using system ICU. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Manual revert Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/libwebviewchromium.gypi

diff --git a/android_webview/libwebviewchromium.gypi b/android_webview/libwebviewchromium.gypi

index 8bd11567b808be70771daf25cc7fa7e45734e7f0..d5c40ed885ecfa2dc1cca89919eb24d900ac523c 100644

--- a/android_webview/libwebviewchromium.gypi

+++ b/android_webview/libwebviewchromium.gypi

@@ -43,7 +43,7 @@

'-Wl,--fatal-warnings',

}],

- ['android_webview_build==1 and use_system_stlport==1', {

+ ['android_webview_build==1 and use_system_stlport==1 and use_system_icu==0', {

# ICU requires RTTI, which is not present in the system's stlport, so

# we have to include gabi++. We can't include it in icu.gyp because

# link_settings cannot be used inside target_conditions. This will be

« no previous file with comments | « no previous file | build/common.gypi » ('j') | no next file with comments »