Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: android_webview/libwebviewchromium.gypi

Issue 570383002: android_webview: go back to using system ICU. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Manual revert Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/common.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 { 4 {
5 'type': 'shared_library', 5 'type': 'shared_library',
6 'android_unmangled_name': 1, 6 'android_unmangled_name': 1,
7 'dependencies': [ 7 'dependencies': [
8 'android_webview_common', 8 'android_webview_common',
9 ], 9 ],
10 'conditions': [ 10 'conditions': [
(...skipping 25 matching lines...) Expand all
36 # When not using the system skia there are linker warnings about 36 # When not using the system skia there are linker warnings about
37 # overriden hidden symbols which there's no easy way to eliminate; 37 # overriden hidden symbols which there's no easy way to eliminate;
38 # disable them. http://crbug.com/157326 38 # disable them. http://crbug.com/157326
39 'ldflags': [ 39 'ldflags': [
40 '-Wl,--no-fatal-warnings', 40 '-Wl,--no-fatal-warnings',
41 ], 41 ],
42 'ldflags!': [ 42 'ldflags!': [
43 '-Wl,--fatal-warnings', 43 '-Wl,--fatal-warnings',
44 ], 44 ],
45 }], 45 }],
46 ['android_webview_build==1 and use_system_stlport==1', { 46 ['android_webview_build==1 and use_system_stlport==1 and use_system_icu==0', {
47 # ICU requires RTTI, which is not present in the system's stlport, so 47 # ICU requires RTTI, which is not present in the system's stlport, so
48 # we have to include gabi++. We can't include it in icu.gyp because 48 # we have to include gabi++. We can't include it in icu.gyp because
49 # link_settings cannot be used inside target_conditions. This will be 49 # link_settings cannot be used inside target_conditions. This will be
50 # removed once we stop using the system stlport. 50 # removed once we stop using the system stlport.
51 # http://crbug.com/409851 51 # http://crbug.com/409851
52 'libraries': [ 52 'libraries': [
53 '-lgabi++', 53 '-lgabi++',
54 ], 54 ],
55 }], 55 }],
56 ], 56 ],
57 'sources': [ 57 'sources': [
58 'lib/main/webview_entry_point.cc', 58 'lib/main/webview_entry_point.cc',
59 ], 59 ],
60 } 60 }
61 61
OLDNEW
« no previous file with comments | « no previous file | build/common.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698