content/renderer/media/android/renderer_media_player_manager.h - Issue 570183002: Make the pause of video playback and video capture consistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/android/renderer_media_player_manager.h

Issue 570183002: Make the pause of video playback and video capture consistent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: also make video playback consistent Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/native/aw_contents.cc ('K') | « content/public/browser/android/content_view_core.h ('k') | content/renderer/media/android/renderer_media_player_manager.cc » ('j') | content/renderer/media/android/renderer_media_player_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/android/renderer_media_player_manager.h

diff --git a/content/renderer/media/android/renderer_media_player_manager.h b/content/renderer/media/android/renderer_media_player_manager.h

index 308f3c3451db81797fa810ca357080e6fd20afd4..6f49c9fae89d6e5684093ca031b73300d3fc5ee8 100644

--- a/content/renderer/media/android/renderer_media_player_manager.h

+++ b/content/renderer/media/android/renderer_media_player_manager.h

@@ -38,6 +38,7 @@ class RendererMediaPlayerManager : public RenderFrameObserver {

// RenderFrameObserver overrides.

virtual bool OnMessageReceived(const IPC::Message& msg) OVERRIDE;

+ virtual void WasHidden() OVERRIDE;

// Initializes a MediaPlayerAndroid object in browser process.

void Initialize(MediaPlayerHostMsg_Initialize_Type type,

@@ -147,7 +148,6 @@ class RendererMediaPlayerManager : public RenderFrameObserver {

void OnPlayerPlay(int player_id);

void OnPlayerPause(int player_id);

void OnRequestFullscreen(int player_id);

- void OnPauseVideo();

// Release all video player resources.

// If something is in progress the resource will not be freed. It will