Make the pause of video playback and video capture consistent

content/renderer/media/android/renderer_media_player_manager.cc

Index: content/renderer/media/android/renderer_media_player_manager.cc
diff --git a/content/renderer/media/android/renderer_media_player_manager.cc b/content/renderer/media/android/renderer_media_player_manager.cc
index 64038e6328273ec4579630579ee97a1f4b0038b8..e969d615a156d4adda05ad5d94c7b6fd602ae047 100644
--- a/content/renderer/media/android/renderer_media_player_manager.cc
+++ b/content/renderer/media/android/renderer_media_player_manager.cc
@@ -55,12 +55,15 @@ bool RendererMediaPlayerManager::OnMessageReceived(const IPC::Message& msg) {
     IPC_MESSAGE_HANDLER(MediaPlayerMsg_DidExitFullscreen, OnDidExitFullscreen)
     IPC_MESSAGE_HANDLER(MediaPlayerMsg_DidMediaPlayerPlay, OnPlayerPlay)
     IPC_MESSAGE_HANDLER(MediaPlayerMsg_DidMediaPlayerPause, OnPlayerPause)
-    IPC_MESSAGE_HANDLER(MediaPlayerMsg_PauseVideo, OnPauseVideo)
   IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
+void RendererMediaPlayerManager::WasHidden() {
+  ReleaseVideoResources();

[xhwang, 2014/09/24 22:52:40]

I like the idea of this CL. But I am not sure how everything is working...

It seems to me this only releases the resources when the video is already
paused:

   if (player && (player->paused() || player->hasVideo()))
     player->ReleaseMediaResources();

Could you please provide more details in comments or CL description how this
work?

Also, do we care about WasShown()? How do we resume playback in that case.
Again, more doc would be helpful.

[michaelbai, 2014/09/24 23:24:08]

Frankly speaking, I just moved ReleaseVideoResources() from one method to
another, did you see any issue here? As I tested, it works fine, and
ReleaseMediaResources() will also be called if player->hasVideo() return true.
No, we don't care about WasShown() and will not resume video automatically, user
has to resume video.

+}
+
 void RendererMediaPlayerManager::Initialize(
     MediaPlayerHostMsg_Initialize_Type type,
     int player_id,
@@ -226,10 +229,6 @@ void RendererMediaPlayerManager::OnRequestFullscreen(int player_id) {
     player->OnRequestFullscreen();
 }
 
-void RendererMediaPlayerManager::OnPauseVideo() {
-  ReleaseVideoResources();
-}
-
 void RendererMediaPlayerManager::EnterFullscreen(int player_id,
                                                  blink::WebFrame* frame) {
   pending_fullscreen_frame_ = frame;