content/browser/android/content_view_core_impl.cc - Issue 570183002: Make the pause of video playback and video capture consistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 570183002: Make the pause of video playback and video capture consistent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: also make video playback consistent Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/native/aw_contents.cc ('K') | « content/browser/android/content_view_core_impl.h ('k') | content/browser/media/android/browser_media_player_manager.h » ('j') | content/renderer/media/android/renderer_media_player_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/content_view_core_impl.cc

diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc

index af52f3513fc587dc16a4fc6571a976e2cae2f6db..1b649db5e54b6ce8c89faace8a539927d229cac6 100644

--- a/content/browser/android/content_view_core_impl.cc

+++ b/content/browser/android/content_view_core_impl.cc

@@ -356,13 +356,6 @@ jint ContentViewCoreImpl::GetBackgroundColor(JNIEnv* env, jobject obj) {

return rwhva->GetCachedBackgroundColor();

}

-void ContentViewCoreImpl::PauseVideo() {

- RenderViewHostImpl* rvhi = static_cast<RenderViewHostImpl*>(

- web_contents_->GetRenderViewHost());

- if (rvhi)

- rvhi->media_web_contents_observer()->PauseVideo();

void ContentViewCoreImpl::PauseOrResumeGeolocation(bool should_pause) {

web_contents_->geolocation_dispatcher_host()->PauseOrResume(should_pause);

}