Chromium Code Reviews| Index: sandbox/linux/seccomp-bpf/errorcode.h |
| diff --git a/sandbox/linux/seccomp-bpf/errorcode.h b/sandbox/linux/seccomp-bpf/errorcode.h |
| index b20b921aa6aad9c2a8f408e20d184a917d730beb..a32241143d631555bc7a154da691f07dacb76b18 100644 |
| --- a/sandbox/linux/seccomp-bpf/errorcode.h |
| +++ b/sandbox/linux/seccomp-bpf/errorcode.h |
| @@ -5,14 +5,11 @@ |
| #ifndef SANDBOX_LINUX_SECCOMP_BPF_ERRORCODE_H__ |
| #define SANDBOX_LINUX_SECCOMP_BPF_ERRORCODE_H__ |
| -#include "sandbox/linux/seccomp-bpf/linux_seccomp.h" |
| #include "sandbox/linux/seccomp-bpf/trap.h" |
| #include "sandbox/sandbox_export.h" |
| namespace sandbox { |
| -struct arch_seccomp_data; |
| - |
| // This class holds all the possible values that can be returned by a sandbox |
| // policy. |
| // We can either wrap a symbolic ErrorCode (i.e. ERR_XXX enum values), an |
| @@ -113,7 +110,7 @@ class SANDBOX_EXPORT ErrorCode { |
| // when compiling a BPF filter, we deliberately generate an invalid |
| // program that will get flagged both by our Verifier class and by |
| // the Linux kernel. |
| - ErrorCode() : error_type_(ET_INVALID), err_(SECCOMP_RET_INVALID) {} |
| + ErrorCode(); |
|
jln (very slow on Chromium)
2014/09/16 20:44:59
Do we still really use the default constructor sin
mdempsky
2014/09/16 20:50:24
Good point. No, it's no longer needed. I've remo
|
| explicit ErrorCode(int err); |
| // For all practical purposes, ErrorCodes are treated as if they were |