Large IWYU cleanup for seccomp-bpf

sandbox/linux/seccomp-bpf/errorcode.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SANDBOX_LINUX_SECCOMP_BPF_ERRORCODE_H__
 #define SANDBOX_LINUX_SECCOMP_BPF_ERRORCODE_H__
 
-#include "sandbox/linux/seccomp-bpf/linux_seccomp.h"
 #include "sandbox/linux/seccomp-bpf/trap.h"
 #include "sandbox/sandbox_export.h"
 
 namespace sandbox {
 
-struct arch_seccomp_data;
-
 // This class holds all the possible values that can be returned by a sandbox
 // policy.
 // We can either wrap a symbolic ErrorCode (i.e. ERR_XXX enum values), an
 // errno value (in the range 0..4095), a pointer to a TrapFnc callback
 // handling a SECCOMP_RET_TRAP trap, or a complex constraint.
 // All of the commonly used values are stored in the "err_" field. So, code
 // that is using the ErrorCode class typically operates on a single 32bit
 // field.
 class SANDBOX_EXPORT ErrorCode {
  public:
@@ skipping 80 matching lines @@
     ET_SIMPLE,
     ET_TRAP,
     ET_COND,
   };
 
   // We allow the default constructor, as it makes the ErrorCode class
   // much easier to use. But if we ever encounter an invalid ErrorCode
   // when compiling a BPF filter, we deliberately generate an invalid
   // program that will get flagged both by our Verifier class and by
   // the Linux kernel.
-  ErrorCode() : error_type_(ET_INVALID), err_(SECCOMP_RET_INVALID) {}
+  ErrorCode();

[jln (very slow on Chromium), 2014/09/16 20:44:59]

Do we still really use the default constructor since your previous change?

[mdempsky, 2014/09/16 20:50:24]

Good point.  No, it's no longer needed.  I've removed it along with ET_INVALID
from the latest patch set.

   explicit ErrorCode(int err);
 
   // For all practical purposes, ErrorCodes are treated as if they were
   // structs. The copy constructor and assignment operator are trivial and
   // we do not need to explicitly specify them.
   // Most notably, it is in fact perfectly OK to directly copy the passed_ and
   // failed_ field. They only ever get set by our private constructor, and the
   // callers handle life-cycle management for these objects.
 
   // Destructor
@@ skipping 62 matching lines @@
 
   // 32bit field used for all possible types of ErrorCode values. This is
   // the value that uniquely identifies any ErrorCode and it (typically) can
   // be emitted directly into a BPF filter program.
   uint32_t err_;
 };
 
 }  // namespace sandbox
 
 #endif  // SANDBOX_LINUX_SECCOMP_BPF_ERRORCODE_H__