Large IWYU cleanup for seccomp-bpf

Large IWYU cleanup for seccomp-bpf

I'm reasonably confident that all of the seccomp-bpf/*.h files are now
IWYU clean. There might still be some missing/superfluous #include lines
in some of the .cc files, but it should overall be much better than
before.

Two particular changes to note:

1. "base/basictypes.h" is deprecated in favor of <stdint.h> (for standard
*int*_t types) and/or "base/macros.h" for DISALLOW_*() macros.

2. This also moves the #include "foo.h" lines to the top of each foo.cc
file, per style guide.

BUG=408845
Committed: https://crrev.com/ab2d46af89c657ab4fd01ab00de1ba2a6ad73f8d
Cr-Commit-Position: refs/heads/master@{#295161}

[mdempsky, 2014-09-16 20:37:16]

mdempsky@chromium.org changed reviewers:
+ jln@chromium.org

[mdempsky, 2014-09-16 20:37:17]

Pretty mechanical; no real code changes except for moving one of ErrorCode's
constructor definitions from errorcode.h into errorcode.cc so I could avoid an
unnecessary #include.

[jln (very slow on Chromium), 2014-09-16 20:45:00]

Very nice cleanup, thanks!

lgtm

https://codereview.chromium.org/570163003/diff/40001/sandbox/linux/seccomp-bp...
File sandbox/linux/seccomp-bpf/errorcode.h (right):

https://codereview.chromium.org/570163003/diff/40001/sandbox/linux/seccomp-bp...
sandbox/linux/seccomp-bpf/errorcode.h:113: ErrorCode();
Do we still really use the default constructor since your previous change?

https://codereview.chromium.org/570163003/diff/40001/sandbox/linux/seccomp-bp...
File sandbox/linux/seccomp-bpf/sandbox_bpf.cc (right):

https://codereview.chromium.org/570163003/diff/40001/sandbox/linux/seccomp-bp...
sandbox/linux/seccomp-bpf/sandbox_bpf.cc:13: #include <linux/filter.h>
nit: alphabetize

[mdempsky, 2014-09-16 20:50:24]

https://codereview.chromium.org/570163003/diff/40001/sandbox/linux/seccomp-bp...
File sandbox/linux/seccomp-bpf/errorcode.h (right):

https://codereview.chromium.org/570163003/diff/40001/sandbox/linux/seccomp-bp...
sandbox/linux/seccomp-bpf/errorcode.h:113: ErrorCode();
On 2014/09/16 20:44:59, jln wrote:
> Do we still really use the default constructor since your previous change?

Good point.  No, it's no longer needed.  I've removed it along with ET_INVALID
from the latest patch set.

[mdempsky, 2014-09-16 20:59:08]

On 2014/09/16 20:50:24, mdempsky wrote:
> Good point.  No, it's no longer needed.  I've removed it along with ET_INVALID
> from the latest patch set.

Doh, but there are still some old unit tests that need the default constructor. 
I'm going to leave it alone for now, and it can just get deleted when I remove
ErrorCode completely.

[mdempsky, 2014-09-16 21:06:14]

https://codereview.chromium.org/570163003/diff/40001/sandbox/linux/seccomp-bp...
File sandbox/linux/seccomp-bpf/sandbox_bpf.cc (right):

https://codereview.chromium.org/570163003/diff/40001/sandbox/linux/seccomp-bp...
sandbox/linux/seccomp-bpf/sandbox_bpf.cc:13: #include <linux/filter.h>
On 2014/09/16 20:45:00, jln wrote:
> nit: alphabetize

Done.

[mdempsky, 2014-09-16 21:06:28]

The CQ bit was checked by mdempsky@chromium.org

[commit-bot: I haz the power, 2014-09-16 21:08:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/570163003/100001

[commit-bot: I haz the power, 2014-09-16 22:35:18]

Committed patchset #6 (id:100001) as f46c8d242c023bc6dfdabaddb66007ea50d89a53

[commit-bot: I haz the power, 2014-09-16 22:36:11]

Patchset 6 (id:??) landed as
https://crrev.com/ab2d46af89c657ab4fd01ab00de1ba2a6ad73f8d
Cr-Commit-Position: refs/heads/master@{#295161}

[aurimas (slooooooooow), 2014-09-17 16:12:08]

On 2014/09/16 22:36:11, I haz the power (commit-bot) wrote:
> Patchset 6 (id:??) landed as
> https://crrev.com/ab2d46af89c657ab4fd01ab00de1ba2a6ad73f8d
> Cr-Commit-Position: refs/heads/master@{#295161}

This change broke Android MIPS builder:
http://build.chromium.org/p/chromium.fyi/builders/Android%20MIPS%20Builder%20...