Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 570083002: Revert of Use a C++11 feature in a single file, to discover if this works everywhere. (Closed)

Created:
6 years, 3 months ago by kevers
Modified:
6 years, 3 months ago
Reviewers:
Nico, awong
CC:
chromium-reviews, erikwright+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Use a C++11 feature in a single file, to discover if this works everywhere. (patchset #5 id:70001 of https://codereview.chromium.org/443483002/) Reason for revert: Breaks Arm compile of Chrome on ChromeOS. http://build.chromium.org/p/chromiumos.chromium/builders/Daisy%20%28chromium%29/builds/1732 chromeos-chrome-39.0.2157.0_alpha-r1: In file included from threading/watchdog.cc:5:0: chromeos-chrome-39.0.2157.0_alpha-r1: ../base/threading/watchdog.h:68:29: error: override controls (override/final) only available with -std=c++11 or -std=gnu++11 [-Werror] chromeos-chrome-39.0.2157.0_alpha-r1: virtual void ThreadMain() OVERRIDE; Original issue's description: > Use a C++11 feature in a single file, to discover if this works everywhere. > > Similar to https://codereview.chromium.org/385743002 , but in a file > that's also built in host targets. Depends on r#294584. > > If your bot can't deal with this, please let me know! > > BUG=none > > Committed: https://crrev.com/5928c2f978a43488a2f45fe7da1d91dfdba1d593 > Cr-Commit-Position: refs/heads/master@{#294687} TBR=ajwong@chromium.org,thakis@chromium.org NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/908d52405f9961fd87d3b65287ab50f67a1d7c1b Cr-Commit-Position: refs/heads/master@{#294822}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M base/compiler_specific.h View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kevers
Created Revert of Use a C++11 feature in a single file, to discover if this ...
6 years, 3 months ago (2014-09-15 14:32:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/570083002/1
6 years, 3 months ago (2014-09-15 14:32:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as ac0c7c214cdf85bf84e4cad4e933406330eec6f4
6 years, 3 months ago (2014-09-15 14:35:50 UTC) #3
Nico
Link to bot? The cros folks told me they are on gcc4.8, where this should ...
6 years, 3 months ago (2014-09-15 14:41:29 UTC) #4
kevers
On 2014/09/15 14:41:29, Nico (hiding) wrote: > Link to bot? The cros folks told me ...
6 years, 3 months ago (2014-09-15 14:53:34 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 15:08:37 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/908d52405f9961fd87d3b65287ab50f67a1d7c1b
Cr-Commit-Position: refs/heads/master@{#294822}

Powered by Google App Engine
This is Rietveld 408576698