Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 385743002: Use a C++11 feature in a single file, to discover if this works everywhere. (Closed)

Created:
6 years, 5 months ago by Nico
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Use a C++11 feature in a single file, to discover if this works everywhere. In theory, as of r284372 all our bots should support using C++11 language features in target builds. (Build targets that are needed in host binaries still can't use it yet, and library features can't be used yet either, see https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/2RzwrIxnvqM ). To test this theory, use a C++11 feature in a file that should be used on most platforms. If this causes problems in many places, this is easy to revert. If your bot can't deal with this, please let me know! BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284444

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
6 years, 5 months ago (2014-07-20 22:25:59 UTC) #1
Nico
assuming green try bots, etc
6 years, 5 months ago (2014-07-20 22:26:19 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-21 15:23:18 UTC) #3
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 5 months ago (2014-07-21 15:35:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/385743002/40001
6 years, 5 months ago (2014-07-21 15:36:25 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 16:43:36 UTC) #6
Message was sent while issue was closed.
Change committed as 284444

Powered by Google App Engine
This is Rietveld 408576698