Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1954)

Unified Diff: Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py

Issue 569913002: fix virtual_test_suites() for browser_test ports (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py b/Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py
index a58d5d5553614bd1106a422bd46da6320ef1f444..20eeb91162f1990e84b53095f7a98ff3ed94b193 100644
--- a/Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py
+++ b/Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py
@@ -30,6 +30,7 @@ import os
import unittest
from webkitpy.common.system import outputcapture
+from webkitpy.common.system.systemhost import SystemHost
Lei Zhang 2014/09/13 17:31:13 nit: alphabetical order?
Dirk Pranke 2014/09/13 22:45:56 whoops. Yeah :).
from webkitpy.common.system.executive_mock import MockExecutive
from webkitpy.common.system.filesystem_mock import MockFileSystem
from webkitpy.layout_tests.port import port_testcase
@@ -128,3 +129,8 @@ class WinPortTest(port_testcase.PortTestCase):
def test_path_to_image_diff(self):
self.assertEqual(self.make_port()._path_to_image_diff(), '/mock-checkout/out/Release/image_diff.exe')
+
+ def test_virtual_test_suites(self):
+ # We override this test to ensure that we're passing a full port name (and hence can run
+ # the test on all platforms).
+ port = self.make_port(host=SystemHost(), port_name='win-win7')
« no previous file with comments | « Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698