Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py

Issue 569913002: fix virtual_test_suites() for browser_test ports (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 12 matching lines...) Expand all
23 # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 23 # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
24 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 24 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
25 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 25 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
26 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 26 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
28 28
29 import os 29 import os
30 import unittest 30 import unittest
31 31
32 from webkitpy.common.system import outputcapture 32 from webkitpy.common.system import outputcapture
33 from webkitpy.common.system.systemhost import SystemHost
Lei Zhang 2014/09/13 17:31:13 nit: alphabetical order?
Dirk Pranke 2014/09/13 22:45:56 whoops. Yeah :).
33 from webkitpy.common.system.executive_mock import MockExecutive 34 from webkitpy.common.system.executive_mock import MockExecutive
34 from webkitpy.common.system.filesystem_mock import MockFileSystem 35 from webkitpy.common.system.filesystem_mock import MockFileSystem
35 from webkitpy.layout_tests.port import port_testcase 36 from webkitpy.layout_tests.port import port_testcase
36 from webkitpy.layout_tests.port import win 37 from webkitpy.layout_tests.port import win
37 from webkitpy.tool.mocktool import MockOptions 38 from webkitpy.tool.mocktool import MockOptions
38 39
39 40
40 class WinPortTest(port_testcase.PortTestCase): 41 class WinPortTest(port_testcase.PortTestCase):
41 port_name = 'win' 42 port_name = 'win'
42 port_maker = win.WinPort 43 port_maker = win.WinPort
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 122
122 def test_operating_system(self): 123 def test_operating_system(self):
123 self.assertEqual('win', self.make_port().operating_system()) 124 self.assertEqual('win', self.make_port().operating_system())
124 125
125 def test_driver_name_option(self): 126 def test_driver_name_option(self):
126 self.assertTrue(self.make_port()._path_to_driver().endswith('content_she ll.exe')) 127 self.assertTrue(self.make_port()._path_to_driver().endswith('content_she ll.exe'))
127 self.assertTrue(self.make_port(options=MockOptions(driver_name='OtherDri ver'))._path_to_driver().endswith('OtherDriver.exe')) 128 self.assertTrue(self.make_port(options=MockOptions(driver_name='OtherDri ver'))._path_to_driver().endswith('OtherDriver.exe'))
128 129
129 def test_path_to_image_diff(self): 130 def test_path_to_image_diff(self):
130 self.assertEqual(self.make_port()._path_to_image_diff(), '/mock-checkout /out/Release/image_diff.exe') 131 self.assertEqual(self.make_port()._path_to_image_diff(), '/mock-checkout /out/Release/image_diff.exe')
132
133 def test_virtual_test_suites(self):
134 # We override this test to ensure that we're passing a full port name (a nd hence can run
135 # the test on all platforms).
136 port = self.make_port(host=SystemHost(), port_name='win-win7')
OLDNEW
« no previous file with comments | « Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698