Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 569713002: Revert of Gardening: Revert "Use AudioStreamMonitor to control power save blocking." (Closed)

Created:
6 years, 3 months ago by DaleCurtis
Modified:
6 years, 3 months ago
CC:
chromium-reviews, creis+watch_chromium.org, posciak+watch_chromium.org, nasko+codewatch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Gardening: Revert "Use AudioStreamMonitor to control power save blocking." (patchset #1 id:1 of https://codereview.chromium.org/562863002/) Reason for revert: Bugs should be fixed now... will CQ this revert. Original issue's description: > Gardening: Revert "Use AudioStreamMonitor to control power save blocking." > > This reverts commit 484d29dcb45ca362fc9049c37dd3a51e11492f14. > > This patch made media/media-controller-playbackrate.html test crash on DEBUG. > > it crashes at content/browser/web_contents/web_contents_impl.cc:4296 on DCHECK > Looks like AddMediaPlayerEntry was called twice for the same player_cookie > > It is not clear how it happens due to async nature of the notification. > The author is sleeping at the moment, so I decided to roll back the patch. > > BUG= > TBR=dalecurtis@chromium.org > > Committed: https://crrev.com/0381a74131887eb13b5d457cce756fb7066411ea > Cr-Commit-Position: refs/heads/master@{#294370} TBR=loislo@chromium.org,jam@chromium.org,miu@chromium.org,scherkus@chromium.org BUG=43667, 367785 Committed: https://chromium.googlesource.com/chromium/src/+/e63ad8aeff3960724ad2625c7574060e6f608158

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+928 lines, -717 lines) Patch
M chrome/browser/media/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/media/audio_stream_monitor.h View 1 chunk +0 lines, -113 lines 0 comments Download
D chrome/browser/media/audio_stream_monitor.cc View 1 chunk +0 lines, -86 lines 0 comments Download
D chrome/browser/media/audio_stream_monitor_unittest.cc View 1 chunk +0 lines, -278 lines 0 comments Download
M chrome/browser/media/media_capture_devices_dispatcher.h View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/media/media_capture_devices_dispatcher.cc View 4 chunks +0 lines, -88 lines 0 comments Download
M chrome/browser/ui/tabs/tab_utils.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/media/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
A content/browser/media/audio_stream_monitor.h View 1 chunk +153 lines, -0 lines 0 comments Download
A content/browser/media/audio_stream_monitor.cc View 1 chunk +162 lines, -0 lines 0 comments Download
A content/browser/media/audio_stream_monitor_unittest.cc View 1 chunk +297 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.cc View 3 chunks +24 lines, -33 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 7 chunks +46 lines, -14 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 10 chunks +129 lines, -42 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 2 chunks +88 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/media_observer.h View 1 chunk +0 lines, -21 lines 0 comments Download
M content/public/browser/web_contents.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/audio/audio_output_controller.h View 5 chunks +15 lines, -7 lines 0 comments Download
M media/audio/audio_output_controller.cc View 5 chunks +3 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
DaleCurtis
Created Revert of Gardening: Revert "Use AudioStreamMonitor to control power save blocking."
6 years, 3 months ago (2014-09-12 17:03:37 UTC) #1
DaleCurtis
6 years, 3 months ago (2014-09-12 17:04:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/569713002/1
6 years, 3 months ago (2014-09-12 17:06:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as e63ad8aeff3960724ad2625c7574060e6f608158
6 years, 3 months ago (2014-09-12 19:25:05 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 19:29:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc6572e179e9fea88a60893d428ab8c3b363113a
Cr-Commit-Position: refs/heads/master@{#294630}

Powered by Google App Engine
This is Rietveld 408576698