Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: remoting/host/client_session.h

Issue 569593002: Maintaining the proper order of initialization WeakPtrFactory in "src/remoting" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/client_session.h
diff --git a/remoting/host/client_session.h b/remoting/host/client_session.h
index f9fdd3bd5c25de4e63bc9839a8b1d2cfe2ba76cf..90de054e168de7e862c81087c748d01a341a4f69 100644
--- a/remoting/host/client_session.h
+++ b/remoting/host/client_session.h
@@ -208,11 +208,6 @@ class ClientSession
protocol::InputFilter auth_input_filter_;
protocol::ClipboardFilter auth_clipboard_filter_;
- // Factory for weak pointers to the client clipboard stub.
- // This must appear after |clipboard_echo_filter_|, so that it won't outlive
- // it.
- base::WeakPtrFactory<protocol::ClipboardStub> client_clipboard_factory_;
Wez 2014/09/12 18:21:52 This doesn't need to move, since it's not a WeakPt
-
// The maximum duration of this session.
// There is no maximum if this value is <= 0.
base::TimeDelta max_duration_;
@@ -263,6 +258,11 @@ class ClientSession
bool lossless_video_encode_;
bool lossless_video_color_;
+ // Factory for weak pointers to the client clipboard stub.
+ // This must appear after |clipboard_echo_filter_|, so that it won't outlive
+ // it.
+ base::WeakPtrFactory<protocol::ClipboardStub> client_clipboard_factory_;
+
DISALLOW_COPY_AND_ASSIGN(ClientSession);
};

Powered by Google App Engine
This is Rietveld 408576698