Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Side by Side Diff: remoting/host/client_session.h

Issue 569593002: Maintaining the proper order of initialization WeakPtrFactory in "src/remoting" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef REMOTING_HOST_CLIENT_SESSION_H_ 5 #ifndef REMOTING_HOST_CLIENT_SESSION_H_
6 #define REMOTING_HOST_CLIENT_SESSION_H_ 6 #define REMOTING_HOST_CLIENT_SESSION_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
(...skipping 190 matching lines...) Expand 10 before | Expand all | Expand 10 after
201 protocol::ClipboardEchoFilter clipboard_echo_filter_; 201 protocol::ClipboardEchoFilter clipboard_echo_filter_;
202 202
203 // Filters used to manage enabling & disabling of input & clipboard. 203 // Filters used to manage enabling & disabling of input & clipboard.
204 protocol::InputFilter disable_input_filter_; 204 protocol::InputFilter disable_input_filter_;
205 protocol::ClipboardFilter disable_clipboard_filter_; 205 protocol::ClipboardFilter disable_clipboard_filter_;
206 206
207 // Filters used to disable input & clipboard when we're not authenticated. 207 // Filters used to disable input & clipboard when we're not authenticated.
208 protocol::InputFilter auth_input_filter_; 208 protocol::InputFilter auth_input_filter_;
209 protocol::ClipboardFilter auth_clipboard_filter_; 209 protocol::ClipboardFilter auth_clipboard_filter_;
210 210
211 // Factory for weak pointers to the client clipboard stub.
212 // This must appear after |clipboard_echo_filter_|, so that it won't outlive
213 // it.
214 base::WeakPtrFactory<protocol::ClipboardStub> client_clipboard_factory_;
Wez 2014/09/12 18:21:52 This doesn't need to move, since it's not a WeakPt
215
216 // The maximum duration of this session. 211 // The maximum duration of this session.
217 // There is no maximum if this value is <= 0. 212 // There is no maximum if this value is <= 0.
218 base::TimeDelta max_duration_; 213 base::TimeDelta max_duration_;
219 214
220 // A timer that triggers a disconnect when the maximum session duration 215 // A timer that triggers a disconnect when the maximum session duration
221 // is reached. 216 // is reached.
222 base::OneShotTimer<ClientSession> max_duration_timer_; 217 base::OneShotTimer<ClientSession> max_duration_timer_;
223 218
224 scoped_refptr<base::SingleThreadTaskRunner> audio_task_runner_; 219 scoped_refptr<base::SingleThreadTaskRunner> audio_task_runner_;
225 scoped_refptr<base::SingleThreadTaskRunner> input_task_runner_; 220 scoped_refptr<base::SingleThreadTaskRunner> input_task_runner_;
(...skipping 30 matching lines...) Expand all
256 scoped_ptr<GnubbyAuthHandler> gnubby_auth_handler_; 251 scoped_ptr<GnubbyAuthHandler> gnubby_auth_handler_;
257 252
258 // Used to manage extension functionality. 253 // Used to manage extension functionality.
259 scoped_ptr<HostExtensionSessionManager> extension_manager_; 254 scoped_ptr<HostExtensionSessionManager> extension_manager_;
260 255
261 // Used to store video channel pause & lossless parameters. 256 // Used to store video channel pause & lossless parameters.
262 bool pause_video_; 257 bool pause_video_;
263 bool lossless_video_encode_; 258 bool lossless_video_encode_;
264 bool lossless_video_color_; 259 bool lossless_video_color_;
265 260
261 // Factory for weak pointers to the client clipboard stub.
262 // This must appear after |clipboard_echo_filter_|, so that it won't outlive
263 // it.
264 base::WeakPtrFactory<protocol::ClipboardStub> client_clipboard_factory_;
265
266 DISALLOW_COPY_AND_ASSIGN(ClientSession); 266 DISALLOW_COPY_AND_ASSIGN(ClientSession);
267 }; 267 };
268 268
269 } // namespace remoting 269 } // namespace remoting
270 270
271 #endif // REMOTING_HOST_CLIENT_SESSION_H_ 271 #endif // REMOTING_HOST_CLIENT_SESSION_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698