[CSSGridLayout] ASSERTION: Bad cast in parseGridTemplateRowsAndAreas

[CSSGridLayout] ASSERTION: Bad cast in parseGridTemplateRowsAndAreas

An empty list of grid line names (represented by "()") does not add anything to
the list of parsed values. That's why trying to concatenate an adjacent list of
grid line names was failing, because we were trying to concatenate a list with
the last parsed CSSValue which was not the expected grid line names list.

BUG=402004
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181915

[svillar, 2014-09-12 10:14:39]

svillar@igalia.com changed reviewers:
+ eae@chromium.org, esprehn@chromium.org, jchaffraix@chromium.org

[svillar, 2014-09-12 10:14:39]

Adding reviewers

[Julien - ping for review, 2014-09-12 14:51:37]

lgtm

https://codereview.chromium.org/569563002/diff/1/Source/core/css/parser/CSSPr...
File Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/569563002/diff/1/Source/core/css/parser/CSSPr...
Source/core/css/parser/CSSPropertyParser.cpp:3361: if (m_valueList->current() &&
m_valueList->current()->unit == CSSParserValue::ValueList)
Nit: We could even remove this branch together:

trailingIdentWasAdded = m_valueList->current() && m_valueList->current()->unit
== CSSParserValue::ValueList && parseGridLineNames(*m_valueList, *templateRows);

I don't know if this would make the code more readable though.

[svillar, 2014-09-12 15:23:41]

The CQ bit was checked by svillar@igalia.com

[commit-bot: I haz the power, 2014-09-12 15:24:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/569563002/1

[commit-bot: I haz the power, 2014-09-12 16:29:25]

Committed patchset #1 (id:1) as 181915