Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: LayoutTests/fast/css-grid-layout/grid-template-shorthand-get-set.html

Issue 569563002: [CSSGridLayout] ASSERTION: Bad cast in parseGridTemplateRowsAndAreas (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/css-grid-layout/grid-template-shorthand-get-set.html
diff --git a/LayoutTests/fast/css-grid-layout/grid-template-shorthand-get-set.html b/LayoutTests/fast/css-grid-layout/grid-template-shorthand-get-set.html
index e51b1b0353e11f0919253203fb6f8f44d3ad3614..5b91158f4ebd49c4dfff6d82ca3d3a9db16dcbf4 100644
--- a/LayoutTests/fast/css-grid-layout/grid-template-shorthand-get-set.html
+++ b/LayoutTests/fast/css-grid-layout/grid-template-shorthand-get-set.html
@@ -42,6 +42,9 @@
#gridTemplateComplexFormOnlyAreas {
grid-template: "a";
}
+#gridTemplateNoColumnsRowWithEmptyTrailingLineNames {
+ grid-template: (first) "a" auto ();
+}
/* Bad values. */
@@ -105,6 +108,12 @@
#gridTemplateComplexFormWithNoneColumns {
grid-template: none / "a" (name) 10px;
}
+#gridTemplateNoColumnsRowWithTwoEmptyTrailingLineNames {
+ grid-template: (first) "a" auto () ();
+}
+#gridTemplateNoColumnsRowWithEmptyTrailingLineNamesAndNonEmptyLeadingLineNames {
+ grid-template: (first) "a" auto () (tail);
+}
</style>
<script src="../../resources/js-test.js"></script>
@@ -122,6 +131,9 @@
<div class="grid" id="gridTemplateComplexFormWithLineNamesMultipleRowsAndColumns"></div>
<div class="grid" id="gridTemplateComplexFormWithAuto"></div>
<div class="grid" id="gridTemplateComplexFormOnlyAreas"></div>
+<div class="grid" id="gridTemplateNoColumnsRowWithEmptyTrailingLineNames"></div>
+<div class="grid" id="gridTemplateNoColumnsRowWithEmptyTrailingLineNamesAndNonEmptyLeadingLineNames"></div>
+<div class="grid" id="gridTemplateNoColumnsRowWithNonEmptyLeadingLineNamesAndEmptyTrailingLineNames"></div>
<div class="grid" id="gridTemplateMultipleSlash"></div>
<div class="grid" id="gridTemplateSimpleFormJustColumns"></div>
<div class="grid" id="gridTemplateSimpleFormNoRows"></div>
@@ -142,6 +154,7 @@
<div class="grid" id="gridTemplateComplexFormColumnsNotParsing1"></div>
<div class="grid" id="gridTemplateComplexFormColumnsNotParsing2"></div>
<div class="grid" id="gridTemplateComplexFormWithNoneColumns"></div>
+<div class="grid" id="gridTemplateNoColumnsRowWithTwoEmptyTrailingLineNames"></div>
<script src="resources/grid-template-shorthand-parsing-utils.js"></script>
<script>
description("This test checks that the 'grid-template' shorthand is properly parsed and the longhand properties correctly assigned.");
@@ -159,6 +172,7 @@
testGridDefinitionsValues(document.getElementById("gridTemplateComplexFormWithLineNamesMultipleRowsAndColumns"), "(first) 10px (nav nav2) 15px (nav nav2) 15px", "100px (nav nav2) 25px (nav nav2) 25px (last)", '"a b c" "d e f" "g h i"');
testGridDefinitionsValues(document.getElementById("gridTemplateComplexFormWithAuto"), "10px", "0px", '"a"');
testGridDefinitionsValues(document.getElementById("gridTemplateComplexFormOnlyAreas"), "none", "0px", '"a"');
+ testGridDefinitionsValues(document.getElementById("gridTemplateNoColumnsRowWithEmptyTrailingLineNames"), "none", "(first) 0px", '"a"');
debug("");
debug("Test getting wrong values for grid-template shorthand through CSS (they should resolve to the default: 'none')");
@@ -182,6 +196,8 @@
testGridDefinitionsValues(document.getElementById("gridTemplateComplexFormColumnsNotParsing1"), "none", "none", "none");
testGridDefinitionsValues(document.getElementById("gridTemplateComplexFormColumnsNotParsing2"), "none", "none", "none");
testGridDefinitionsValues(document.getElementById("gridTemplateComplexFormWithNoneColumns"), "none", "none", "none");
+ testGridDefinitionsValues(document.getElementById("gridTemplateNoColumnsRowWithTwoEmptyTrailingLineNames"), "none", "none", "none");
+ testGridDefinitionsValues(document.getElementById("gridTemplateNoColumnsRowWithEmptyTrailingLineNamesAndNonEmptyLeadingLineNames"), "none", "none", "none");
debug("");
debug("Test the initial value");

Powered by Google App Engine
This is Rietveld 408576698