Issue 569313004: Fix leak in PictureNestingBench

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 569313004: Fix leak in PictureNestingBench (Closed)

Created:
6 years, 3 months ago by f(malita)

Modified:
6 years, 3 months ago

Reviewers:
tfarina, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Fix leak in PictureNestingBench TBR=mtklein@google.com Committed: https://skia.googlesource.com/skia/+/df886ea06f0978e10695b482e658cf3daa9a1fc9

Patch Set 1 #

Total comments: 1

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	bench/PictureNestingBench.cpp	View		1 chunk	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/569313004/1

6 years, 3 months ago (2014-09-16 01:12:28 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as df886ea06f0978e10695b482e658cf3daa9a1fc9

6 years, 3 months ago (2014-09-16 01:20:16 UTC) #3

tfarina

6 years, 3 months ago (2014-09-17 16:42:34 UTC) #5

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/569313004/diff/1/bench/PictureNestingBench.cpp
File bench/PictureNestingBench.cpp (right):

https://codereview.chromium.org/569313004/diff/1/bench/PictureNestingBench.cp...
bench/PictureNestingBench.cpp:26: SkAutoTUnref<SkCanvas>
nullCanvas(SkCreateNullCanvas());
looks right, since nothing in sierpinsky() takes ownership of the created
SkCanvas.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages