bench/PictureNestingBench.cpp - Issue 569313004: Fix leak in PictureNestingBench

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: bench/PictureNestingBench.cpp

Issue 569313004: Fix leak in PictureNestingBench (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: bench/PictureNestingBench.cpp

diff --git a/bench/PictureNestingBench.cpp b/bench/PictureNestingBench.cpp

index aecd7ed34503125a25af2a78f1e7edeffa72a2df..f1adb6084026d9703cae83a502425a43cbb1137c 100644

--- a/bench/PictureNestingBench.cpp

+++ b/bench/PictureNestingBench.cpp

@@ -23,8 +23,8 @@ public:

fPaint.setColor(SK_ColorRED);

fPaint.setAntiAlias(true);

fPaint.setStyle(SkPaint::kStroke_Style);

- fName.printf("picture_nesting_%s_%d", name,

- this->sierpinsky(SkCreateNullCanvas(), 0, fPaint));

+ SkAutoTUnref<SkCanvas> nullCanvas(SkCreateNullCanvas());

tfarina 2014/09/17 16:42:34 looks right, since nothing in sierpinsky() takes o

+ fName.printf("picture_nesting_%s_%d", name, this->sierpinsky(nullCanvas, 0, fPaint));

}

protected:

« no previous file with comments | « no previous file | no next file » | no next file with comments »