Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Unified Diff: chrome/renderer/translate/translate_helper.h

Issue 569233002: Refactoring the order of the weak_ptr_factory in chrome/renderer folder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/printing/print_web_view_helper.h ('k') | chrome/renderer/translate/translate_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/translate/translate_helper.h
diff --git a/chrome/renderer/translate/translate_helper.h b/chrome/renderer/translate/translate_helper.h
index cc70eaa36a32ac25793d67e95b9934bf0dd20765..8b98376b35480f265471457a8d103ae36a7a6196 100644
--- a/chrome/renderer/translate/translate_helper.h
+++ b/chrome/renderer/translate/translate_helper.h
@@ -238,9 +238,6 @@ class TranslateHelper : public content::RenderViewObserver {
// time from showing infobar to requesting translation.
base::TimeTicks language_determined_time_;
- // Method factory used to make calls to TranslatePageImpl.
- base::WeakPtrFactory<TranslateHelper> weak_method_factory_;
-
// Provides CLD data for this process.
scoped_ptr<translate::RendererCldDataProvider> cld_data_provider_;
@@ -262,6 +259,9 @@ class TranslateHelper : public content::RenderViewObserver {
// deferred_page_capture_ is true.
base::string16 deferred_contents_;
+ // Method factory used to make calls to TranslatePageImpl.
+ base::WeakPtrFactory<TranslateHelper> weak_method_factory_;
+
DISALLOW_COPY_AND_ASSIGN(TranslateHelper);
};
« no previous file with comments | « chrome/renderer/printing/print_web_view_helper.h ('k') | chrome/renderer/translate/translate_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698