Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 569203002: Adding DumpAccessibilityTree Tests (7 of 20) (Closed)

Created:
6 years, 3 months ago by shreeramk
Modified:
6 years, 3 months ago
Reviewers:
dmazzoni, aboxhall
CC:
chromium-reviews, plundblad+watch_chromium.org, mkwst+moarreviews-content_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adding DumpAccessibilityTree Tests (7 of 20) HTML Tags: abbr, button, col, figure, meta, meter, input type(search, time) Aria role: log, marquee Aria state/property: aria-orientation(horizontal, vertical), aria-sort(Ascending, Descending, Other) BUG=170579 Committed: https://crrev.com/235fd06a8b60d37606ac7c6f40e8ece9a0bc607a Cr-Commit-Position: refs/heads/master@{#296157}

Patch Set 1 #

Patch Set 2 : Adding expectations for mac and android #

Patch Set 3 : Updating expectations for mac and android #

Patch Set 4 : #

Total comments: 3

Patch Set 5 : Updated according to comments #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+358 lines, -16 lines) Patch
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 2 3 4 5 9 chunks +49 lines, -0 lines 0 comments Download
A content/test/data/accessibility/abbr.html View 1 1 chunk +9 lines, -0 lines 0 comments Download
A content/test/data/accessibility/abbr-expected-android.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
A content/test/data/accessibility/abbr-expected-mac.txt View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
A content/test/data/accessibility/abbr-expected-win.txt View 1 chunk +6 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria-log.html View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
A + content/test/data/accessibility/aria-log-expected-android.txt View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A content/test/data/accessibility/aria-log-expected-mac.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria-log-expected-win.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A content/test/data/accessibility/aria-marquee.html View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria-marquee-expected-android.txt View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A content/test/data/accessibility/aria-marquee-expected-mac.txt View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-marquee-expected-win.txt View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-orientation.html View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-orientation-expected-android.txt View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-orientation-expected-mac.txt View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-orientation-expected-win.txt View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-sort.html View 1 1 chunk +42 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-sort-expected-android.txt View 1 1 chunk +28 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-sort-expected-mac.txt View 1 1 chunk +37 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-sort-expected-win.txt View 1 1 chunk +37 lines, -0 lines 0 comments Download
A content/test/data/accessibility/button.html View 1 1 chunk +9 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/button-expected-android.txt View 1 1 chunk +1 line, -1 line 0 comments Download
A content/test/data/accessibility/button-expected-mac.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/button-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
A + content/test/data/accessibility/col.html View 1 chunk +5 lines, -7 lines 0 comments Download
A content/test/data/accessibility/col-expected-android.txt View 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/col-expected-mac.txt View 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/col-expected-win.txt View 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/figure.html View 1 1 chunk +11 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/figure-expected-android.txt View 1 1 chunk +1 line, -1 line 0 comments Download
A content/test/data/accessibility/figure-expected-mac.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/figure-expected-win.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/input-search.html View 1 1 chunk +10 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/input-search-expected-android.txt View 1 1 chunk +1 line, -1 line 0 comments Download
A content/test/data/accessibility/input-search-expected-mac.txt View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/input-search-expected-win.txt View 1 chunk +0 lines, -1 line 0 comments Download
A content/test/data/accessibility/input-time.html View 1 1 chunk +9 lines, -0 lines 0 comments Download
A content/test/data/accessibility/input-time-expected-android.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/input-time-expected-mac.txt View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
A content/test/data/accessibility/input-time-expected-win.txt View 1 chunk +12 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/meta.html View 1 chunk +3 lines, -2 lines 0 comments Download
A content/test/data/accessibility/meta-expected-android.txt View 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/meta-expected-mac.txt View 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/meta-expected-win.txt View 1 chunk +1 line, -0 lines 0 comments Download
A + content/test/data/accessibility/meter.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + content/test/data/accessibility/meter-expected-android.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A content/test/data/accessibility/meter-expected-mac.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/meter-expected-win.txt View 1 chunk +0 lines, -1 line 0 comments Download
A content/test/data/accessibility/pipe.jpg View 1 Binary file 0 comments Download

Messages

Total messages: 14 (4 generated)
shreeramk
Please review. Thanks!!
6 years, 3 months ago (2014-09-16 08:13:43 UTC) #2
shreeramk
On 2014/09/16 08:13:43, shreeram.k wrote: > Please review. Thanks!! @dmazzoni: PTAL
6 years, 3 months ago (2014-09-19 06:40:53 UTC) #3
dmazzoni
Looks great, I only see two small issues. https://codereview.chromium.org/569203002/diff/60001/content/test/data/accessibility/aria-log.html File content/test/data/accessibility/aria-log.html (right): https://codereview.chromium.org/569203002/diff/60001/content/test/data/accessibility/aria-log.html#newcode8 content/test/data/accessibility/aria-log.html:8: <div ...
6 years, 3 months ago (2014-09-22 21:16:36 UTC) #4
shreeramk
PTAL! I updated aria-log.html and aria-marquee.html. https://codereview.chromium.org/569203002/diff/60001/content/test/data/accessibility/aria-orientation-expected-win.txt File content/test/data/accessibility/aria-orientation-expected-win.txt (right): https://codereview.chromium.org/569203002/diff/60001/content/test/data/accessibility/aria-orientation-expected-win.txt#newcode2 content/test/data/accessibility/aria-orientation-expected-win.txt:2: ROLE_SYSTEM_SCROLLBAR On 2014/09/22 ...
6 years, 3 months ago (2014-09-23 05:30:10 UTC) #5
dmazzoni
lgtm Thanks!
6 years, 3 months ago (2014-09-23 05:38:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/569203002/80001
6 years, 3 months ago (2014-09-23 05:39:30 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/59349) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/17494) mac_chromium_rel_swarming ...
6 years, 3 months ago (2014-09-23 05:43:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/569203002/100001
6 years, 3 months ago (2014-09-23 06:13:41 UTC) #12
commit-bot: I haz the power
Committed patchset #6 (id:100001) as 001d1602f251c68fd0b09e5b153435e2d8380f26
6 years, 3 months ago (2014-09-23 08:30:38 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 08:31:17 UTC) #14
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/235fd06a8b60d37606ac7c6f40e8ece9a0bc607a
Cr-Commit-Position: refs/heads/master@{#296157}

Powered by Google App Engine
This is Rietveld 408576698