DevTools: disallow to start stop tracing using console.timeline/timelineEnd

DevTools: disallow to start stop tracing using console.timeline/timelineEnd

We are going deprecate console.timeline/timelineEnd. As the first step they will result only in time/timeEnd events and won't start/stop tracing. This change removes the code that allows to change browser wide tracing recording from the render process, it mostly reverts part of r292578.

BUG=412782
TBR=dcheng

Committed: https://crrev.com/d10b46af79743ec6afc3256972d7fa5ec26085c3
Cr-Commit-Position: refs/heads/master@{#294860}

[yurys, 2014-09-15 09:05:22]

yurys@chromium.org changed reviewers:
+ alph@chromium.org, caseq@chromium.org, loislo@chromium.org,
pfeldman@chromium.org

[alph, 2014-09-15 09:56:40]

lgtm

https://codereview.chromium.org/569153004/diff/20001/content/renderer/devtool...
File content/renderer/devtools/devtools_agent.cc (left):

https://codereview.chromium.org/569153004/diff/20001/content/renderer/devtool...
content/renderer/devtools/devtools_agent.cc:174: Send(new
DevToolsHostMsg_EnableTracing(routing_id(), category_filter.utf8()));
Drop these from devtools_messages.h ?

[caseq, 2014-09-15 11:38:18]

lgtm

https://codereview.chromium.org/569153004/diff/20001/content/browser/devtools...
File content/browser/devtools/devtools_tracing_handler.cc (right):

https://codereview.chromium.org/569153004/diff/20001/content/browser/devtools...
content/browser/devtools/devtools_tracing_handler.cc:152: return
command->InternalErrorResponse("Tracing is already started.");
nit: we don't use terminating punctuation in protocol errors.

https://codereview.chromium.org/569153004/diff/20001/content/browser/devtools...
content/browser/devtools/devtools_tracing_handler.cc:229: return
command->InternalErrorResponse("Tracing is not started.");
ditto.

https://codereview.chromium.org/569153004/diff/20001/content/browser/devtools...
content/browser/devtools/devtools_tracing_handler.cc:232:
base::Bind(&DevToolsTracingHandler::BeginReadingRecordingResult,
You'll need to rebaseline this against r294801.

[yurys, 2014-09-15 12:02:18]

https://codereview.chromium.org/569153004/diff/20001/content/browser/devtools...
File content/browser/devtools/devtools_tracing_handler.cc (right):

https://codereview.chromium.org/569153004/diff/20001/content/browser/devtools...
content/browser/devtools/devtools_tracing_handler.cc:152: return
command->InternalErrorResponse("Tracing is already started.");
On 2014/09/15 11:38:17, caseq wrote:
> nit: we don't use terminating punctuation in protocol errors.

Done.

https://codereview.chromium.org/569153004/diff/20001/content/browser/devtools...
content/browser/devtools/devtools_tracing_handler.cc:229: return
command->InternalErrorResponse("Tracing is not started.");
On 2014/09/15 11:38:17, caseq wrote:
> ditto.

Done.

https://codereview.chromium.org/569153004/diff/20001/content/browser/devtools...
content/browser/devtools/devtools_tracing_handler.cc:232:
base::Bind(&DevToolsTracingHandler::BeginReadingRecordingResult,
On 2014/09/15 11:38:17, caseq wrote:
> You'll need to rebaseline this against r294801.

Done.

https://codereview.chromium.org/569153004/diff/20001/content/renderer/devtool...
File content/renderer/devtools/devtools_agent.cc (left):

https://codereview.chromium.org/569153004/diff/20001/content/renderer/devtool...
content/renderer/devtools/devtools_agent.cc:174: Send(new
DevToolsHostMsg_EnableTracing(routing_id(), category_filter.utf8()));
On 2014/09/15 09:56:40, alph wrote:
> Drop these from devtools_messages.h ?

Done.

[yurys, 2014-09-15 12:02:59]

yurys@chromium.org changed reviewers:
+ dcheng@chromium.org

[yurys, 2014-09-15 12:03:00]

@dcheng: please do OWNERS review of changes in
content/common/devtools_messages.h

[yurys, 2014-09-15 16:39:11]

The CQ bit was checked by yurys@chromium.org

[commit-bot: I haz the power, 2014-09-15 16:50:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/569153004/40001

[commit-bot: I haz the power, 2014-09-15 18:58:33]

Committed patchset #3 (id:40001) as a139ea43caa3cbbc88f36417bd5156718ffe6954

[commit-bot: I haz the power, 2014-09-15 19:03:43]

Patchset 3 (id:??) landed as
https://crrev.com/d10b46af79743ec6afc3256972d7fa5ec26085c3
Cr-Commit-Position: refs/heads/master@{#294860}