Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: content/browser/devtools/devtools_tracing_handler.h

Issue 569153004: DevTools: disallow to start stop tracing using console.timeline/timelineEnd (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/devtools/devtools_tracing_handler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_TRACING_HANDLER_H_ 5 #ifndef CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_TRACING_HANDLER_H_
6 #define CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_TRACING_HANDLER_H_ 6 #define CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_TRACING_HANDLER_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 10
(...skipping 12 matching lines...) Expand all
23 // This class bridges DevTools remote debugging server with the trace 23 // This class bridges DevTools remote debugging server with the trace
24 // infrastructure. 24 // infrastructure.
25 class DevToolsTracingHandler : public DevToolsProtocol::Handler { 25 class DevToolsTracingHandler : public DevToolsProtocol::Handler {
26 public: 26 public:
27 enum Target { Browser, Renderer }; 27 enum Target { Browser, Renderer };
28 explicit DevToolsTracingHandler(Target target); 28 explicit DevToolsTracingHandler(Target target);
29 virtual ~DevToolsTracingHandler(); 29 virtual ~DevToolsTracingHandler();
30 30
31 void OnClientDetached(); 31 void OnClientDetached();
32 32
33 void EnableTracing(const std::string& category_filter);
34 void DisableTracing();
35
36 void OnTraceDataCollected(const std::string& trace_fragment); 33 void OnTraceDataCollected(const std::string& trace_fragment);
37 void OnTraceComplete(); 34 void OnTraceComplete();
38 35
39 private: 36 private:
40 void OnRecordingEnabled(scoped_refptr<DevToolsProtocol::Command> command); 37 void OnRecordingEnabled(scoped_refptr<DevToolsProtocol::Command> command);
41 void OnBufferUsage(float usage); 38 void OnBufferUsage(float usage);
42 39
43 scoped_refptr<DevToolsProtocol::Response> OnStart( 40 scoped_refptr<DevToolsProtocol::Response> OnStart(
44 scoped_refptr<DevToolsProtocol::Command> command); 41 scoped_refptr<DevToolsProtocol::Command> command);
45 scoped_refptr<DevToolsProtocol::Response> OnEnd( 42 scoped_refptr<DevToolsProtocol::Response> OnEnd(
(...skipping 19 matching lines...) Expand all
65 static const char* kDefaultCategories; 62 static const char* kDefaultCategories;
66 static const double kDefaultReportingInterval; 63 static const double kDefaultReportingInterval;
67 static const double kMinimumReportingInterval; 64 static const double kMinimumReportingInterval;
68 65
69 DISALLOW_COPY_AND_ASSIGN(DevToolsTracingHandler); 66 DISALLOW_COPY_AND_ASSIGN(DevToolsTracingHandler);
70 }; 67 };
71 68
72 } // namespace content 69 } // namespace content
73 70
74 #endif // CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_TRACING_HANDLER_H_ 71 #endif // CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_TRACING_HANDLER_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/devtools/devtools_tracing_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698