Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 569063002: Reland [blink-in-js] Migrate resources required for blink-in-js to grd - part 3 (Closed)

Created:
6 years, 3 months ago by vivekg_samsung
Modified:
6 years, 3 months ago
CC:
abarth-chromium, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Reland [blink-in-js] Migrate resources required for blink-in-js to grd - part 3 The earlier commit for this was reverted here https://codereview.chromium.org/557543004 as it broke the compilation on Linux GN (dbg) which is tree closer. http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20(dbg) Adding the changes required, the flag --for-testing, in the Source/core/BUILD.gn to include this flag. BUG=312586 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181971

Patch Set 1 #

Patch Set 2 : Rebased patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -18 lines) Patch
M Source/bindings/core/v8/PrivateScriptRunner.cpp View 4 chunks +7 lines, -4 lines 0 comments Download
M Source/build/scripts/make_private_script_source.py View 2 chunks +31 lines, -13 lines 0 comments Download
M Source/core/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/core_generated.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A Source/platform/PlatformResourceLoader.h View 1 chunk +17 lines, -0 lines 0 comments Download
A Source/platform/PlatformResourceLoader.cpp View 1 chunk +21 lines, -0 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
vivekg
PTAL, thanks!
6 years, 3 months ago (2014-09-14 00:17:17 UTC) #3
haraken
On 2014/09/14 00:17:17, vivekg_ wrote: > PTAL, thanks! The bots are red, but are they ...
6 years, 3 months ago (2014-09-14 04:17:03 UTC) #4
vivekg
On 2014/09/14 at 04:17:03, haraken wrote: > On 2014/09/14 00:17:17, vivekg_ wrote: > > PTAL, ...
6 years, 3 months ago (2014-09-14 04:20:04 UTC) #5
haraken
On 2014/09/14 04:20:04, vivekg_ wrote: > On 2014/09/14 at 04:17:03, haraken wrote: > > On ...
6 years, 3 months ago (2014-09-14 04:20:45 UTC) #6
vivekg
On 2014/09/14 at 04:20:45, haraken wrote: > On 2014/09/14 04:20:04, vivekg_ wrote: > > On ...
6 years, 3 months ago (2014-09-14 04:37:19 UTC) #7
vivekg
Looks like there is a lot of flakiness with the debug bots. All of them ...
6 years, 3 months ago (2014-09-15 07:17:59 UTC) #8
vivekg
All green. Going for CQ with fingers crossed.
6 years, 3 months ago (2014-09-15 09:29:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/569063002/20001
6 years, 3 months ago (2014-09-15 09:29:45 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 10:09:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 181971

Powered by Google App Engine
This is Rietveld 408576698