Issue 557543004: Revert "[blink-in-js] Migrate resources required for blink-in-js to grd - part 3"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 557543004: Revert "[blink-in-js] Migrate resources required for blink-in-js to grd - part 3" (Closed)

Created:
6 years, 3 months ago by loislo

Modified:
6 years, 3 months ago

Reviewers:
haraken, Dirk Pranke, jochen (gone - plz use gerrit)

CC:
blink-reviews, blink-reviews-bindings_chromium.org, mkwst+moarreviews_chromium.org, arv+blink, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Revert "[blink-in-js] Migrate resources required for blink-in-js to grd - part 3" This reverts commit 0ad77c5152a930f08e04a2db05ad5331c711333f. It breaks compilation on Linux GN (dbg) which is tree closer. http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20(dbg) BUG=312586 TBR= dpranke@chromium.org, haraken@chromium.org, jochen@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181957

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -79 lines)			Patch
M	Source/bindings/core/v8/PrivateScriptRunner.cpp	View	4 chunks	+4 lines, -7 lines	0 comments	Download
M	Source/build/scripts/make_private_script_source.py	View	2 chunks	+13 lines, -31 lines	0 comments	Download
M	Source/core/core_generated.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	Source/platform/PlatformResourceLoader.h	View	1 chunk	+0 lines, -17 lines	0 comments	Download
D	Source/platform/PlatformResourceLoader.cpp	View	1 chunk	+0 lines, -21 lines	0 comments	Download
M	Source/platform/blink_platform.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/557543004/1

6 years, 3 months ago (2014-09-13 16:36:26 UTC) #2

loislo

http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/12223/steps/compile/logs/stdio

6 years, 3 months ago (2014-09-13 16:37:14 UTC) #3

commit-bot: I haz the power

Committed patchset #1 (id:1) as 181957

6 years, 3 months ago (2014-09-13 17:55:01 UTC) #4

Message was sent while issue was closed.

LGTM