Issue 5689005: Land Vitaly's change to fix compare IC performance....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5689005: Land Vitaly's change to fix compare IC performance.... (Closed)

Created:
10 years ago by fschneider

Modified:
9 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Land Vitaly's change to fix compare IC performance. Original change: http://codereview.chromium.org/5733004/ When we have inlined smi code can transition to heap number state before going to the generic state. Without inlined smi code the behaviour is unchanged. Committed: http://code.google.com/p/v8/source/detail?r=5975

Patch Set 1 #

Total comments: 1

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -6 lines)			Patch
M	src/ia32/ic-ia32.cc	View	1 chunk	+12 lines, -1 line	0 comments	Download
M	src/ic.h	View	1 chunk	+2 lines, -1 line	1 comment	Download
M	src/ic.cc	View	1 chunk	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

10 years ago (2010-12-13 09:56:41 UTC) #2

LGTM

http://codereview.chromium.org/5689005/diff/1/src/ic.h
File src/ic.h (right):

http://codereview.chromium.org/5689005/diff/1/src/ic.h#newcode585
src/ic.h:585: State TargetState(State state, bool has_inlined_smi_code,
we do not format arguments this way.

Expand Messages | Collapse Messages